azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Dev storagecache microsoft.storage cache 2023 03 01 preview

Open brpanask opened this issue 3 years ago • 16 comments

This takes the amlfilesystem content from the 2021-11-01-preview api for storagecache Microsoft.StorageCache and adds the new public preview api 2023-03-01-preview version.

This 2023-03-01-preview version is based on storagecache 2022-05-01 version and the previously approved 2021-11-01-preview version's amlfilesystem content.

The amlfilesystem is a new resource that is currently in private preview and this api version will move it to public preview.

The only changes from the preview version of amlfilesystem content was the move to use a separate amlfilesystem.json file instead of adding it to the existing storagecache.json and to remove the management subnet that was in the private preview.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. 2022-10.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 2022-11
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

brpanask avatar Jul 08 '22 19:07 brpanask

Hi, @brpanask Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Hi, @brpanask your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 11 Errors, 54 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    storagecache.json 2023-03-01-preview(0c61c31) 2022-05-01(main)
    storagecache.json 2023-03-01-preview(0c61c31) 2019-08-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupParameter' removed or renamed?
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L3481:3
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L3250:3
    1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L547:11
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Cancelled' from the old version.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2119:13
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L1920:13
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Cancelled' from the old version.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2835:9
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L2624:9
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2387:11
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L2188:11
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L463:11
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L461:11
    1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1081:11
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L1001:11
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2455:9
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L2252:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2460:9
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L2256:9
    1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2465:9
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L2260:9
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L511:7
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L508:7
    :warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L3363:9
    Old: Microsoft.StorageCache/stable/2022-05-01/storagecache.json#L3132:9


    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    :warning: 1008 - ModifiedOperationId The operation id has been changed from 'Caches_Create' to 'Caches_CreateOrUpdate'. This will impact generated code.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L443:7
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L364:7
    :warning: 1008 - ModifiedOperationId The operation id has been changed from 'StorageTargets_Create' to 'StorageTargets_CreateOrUpdate'. This will impact generated code.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1058:7
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L854:7
    :warning: 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L486:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L547:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L746:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L808:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L870:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1104:11
    :warning: 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1697:11
    :warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2763:9
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1509:9
    :warning: 1019 - RemovedEnumValue The new version is removing enum value(s) 'Cancelled' from the old version.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2119:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1190:13
    :warning: 1019 - RemovedEnumValue The new version is removing enum value(s) 'Cancelled' from the old version.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2835:9
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1534:13
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2091:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1173:13
    :warning: 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L463:11
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L393:11
    :warning: 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2808:7
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1513:11
    :warning: 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1081:11
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L891:11
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2119:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1190:13
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2835:9
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1534:13
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L3140:11
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1594:11
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1036:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L832:13
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1086:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L895:13
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1094:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L903:13
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1100:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L909:13
    :warning: 1030 - DifferentDiscriminator The new version has a different discriminator than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2754:5
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1489:5
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L3140:11
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1594:11
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1036:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L832:13
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1086:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L895:13
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1094:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L903:13
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1100:13
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L909:13
    :warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L2754:5
    Old: Microsoft.StorageCache/preview/2019-08-01-preview/storagecache.json#L1489:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 3 Errors, 2 Warnings failed [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-03 package-preview-2023-03(0c61c31) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    LongRunningResponseStatusCode A 'delete' operation 'amlFilesystems_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L126
    RPC-Async-V1-01
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L320
    RPC-Patch-V1-11
    PatchSkuProperty The patch operation body parameter schema should contains property 'sku'.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L320
    RPC-Patch-V1-09
    :warning: AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L633
    :warning: AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/amlfilesystem.json#L772


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L297
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L342
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L343
    LongRunningResponseStatusCode A 'delete' operation 'Caches_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L343
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L443
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L486
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L486
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L531
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L531
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L531
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L586
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L587
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L648
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L649
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L710
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L711
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L772
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L773
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L834
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L835
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L896
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L944
    TrackedResourcePatchOperation Tracked resource 'StorageTarget' must have patch operation that at least supports the update of tags.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L944
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L945
    LongRunningResponseStatusCode A 'delete' operation 'StorageTargets_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L945
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1058
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1104
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1104
    SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1133
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json#L1134
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.StorageCache' for api version '2023-03-01-preview'. The supported api-versions are '2019-08-01-preview,
    2019-11-01,
    2020-03-01,
    2020-10-01,
    2021-03-01,
    2021-05-01,
    2021-09-01,
    2021-10-01-preview,
    2021-11-01-preview,
    2022-01-01,
    2022-05-01,
    2022-09-01-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.13.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.13.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
      cmdout	[automation_generate.sh] [Autorest] AutoRest code generation utility [cli version: 3.6.1; node: v14.15.0]
      cmdout	[automation_generate.sh] [Autorest] (C) 2018 Microsoft Corporation.
      cmdout	[automation_generate.sh] [Autorest] https://aka.ms/autorest
      cmdout	[automation_generate.sh] [Autorest] info    | AutoRest core version selected from configuration: 3.7.2.
      cmdout	[automation_generate.sh] [Autorest] SourceMapConsumer.initialize is a no-op when running in node.js
      cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.7.2)
      cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmdout	[automation_generate.sh] [Autorest] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'userAssignedIdentitiesValue' (2 differences):
      cmdout	[automation_generate.sh] [Autorest]   - properties.principalId.$ref: "#/components/schemas/schemas:53" => "#/components/schemas/schemas:245"
      cmdout	[automation_generate.sh] [Autorest]   - properties.clientId.$ref: "#/components/schemas/schemas:54" => "#/components/schemas/schemas:246"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
      cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
      cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
      cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin prechecker reported failure.
      cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
      warn	Skip package processing as generation is failed
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] FATAL: swagger-document/compose - FAILED
      cmderr	[Autorest] FATAL: Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
      cmderr	[Autorest]   -
      cmderr	[Autorest]   Subscription credentials which uniquely identify Microsoft Azure subscription.
      cmderr	[Autorest]   The subscription ID forms part of the URI for every service call.
      cmderr	[Autorest] , ---
      cmderr	[Autorest] The ID of the target subscription.
      cmderr	[Autorest] ).
      cmderr	[Autorest]   Error: '$.parameters.SubscriptionIdParameter.description' has incompatible values (---
      cmderr	[Autorest]   -
      cmderr	[Autorest]   Subscription credentials which uniquely identify Microsoft Azure subscription.
      cmderr	[Autorest]   The subscription ID forms part of the URI for every service call.
      cmderr	[Autorest] , ---
      cmderr	[Autorest] The ID of the target subscription.
      cmderr	[Autorest] ).
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Preview SDK Changes]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation-v2] [ERROR] total 1 error(s):
      cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storagecache/armstoragecache[0m
      cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/storagecache/armstoragecache, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storagecache/armstoragecache
      cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storagecache/armstoragecache
      cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storagecache/armstoragecache
      cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v14.19.3]
      cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
      cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
      cmderr	[generator automation-v2] [ERROR] info    | AutoRest core version selected from configuration: 3.8.2.
      cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.8.2)
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.43 -> 4.0.0-preview.43)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.43->4.0.0-preview.43)
      cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.23.1 -> 4.23.1)
      cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.23.1->4.23.1)
      cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > AscOperation > properties > error)
      cmderr	[generator automation-v2] [ERROR] keys: [ [32m'type'[39m ]
      cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2022-11-01-preview/storagecache.json:1813:9
      cmderr	[generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData)
      cmderr	[generator automation-v2] [ERROR] keys: [ [32m'type'[39m ]
      cmderr	[generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
      cmderr	[generator automation-v2] [ERROR] error   | PreCheck/DuplicateSchema | Duplicate Schema named 'userAssignedIdentitiesValue' (2 differences):
      cmderr	[generator automation-v2] [ERROR] - properties.principalId.$ref: "#/components/schemas/schemas:53" => "#/components/schemas/schemas:245"
      cmderr	[generator automation-v2] [ERROR] - properties.clientId.$ref: "#/components/schemas/schemas:54" => "#/components/schemas/schemas:246"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting.  NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that.
      cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.
      cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
      cmderr	[generator automation-v2] [ERROR] error   |   Error: Plugin prechecker reported failure.
      cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
      cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
      cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh.exe": exit status 1
      cmderr	[generator automation-v2] [ERROR] ': exit status 1
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
      warn	Skip package processing as generation is failed
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️storagecache [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 39ecef97a9bc711ac44077858a83eb96cda0b52a. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.storagecache [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Hi @brpanask, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-go - sdk/resourcemanager/storagecache/armstoragecache - 3.0.0
    +	Function `*CachesClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, Cache, *CachesClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, *CachesClientBeginCreateOrUpdateOptions)`
    +	Function `*CachesClient.Update` parameter(s) have been changed from `(context.Context, string, string, Cache, *CachesClientUpdateOptions)` to `(context.Context, string, string, *CachesClientUpdateOptions)`
    +	Function `*StorageTargetsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, StorageTarget, *StorageTargetsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, *StorageTargetsClientBeginCreateOrUpdateOptions)`
    +	Struct `CloudError` has been removed
    +	Type of `AscOperationProperties.Output` has been changed from `map[string]interface{}` to `map[string]any`

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-storagecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation StorageTargetsOperations.begin_restore_defaults
      info	[Changelog]   - Model BlobNfsTarget has a new parameter verification_timer
      info	[Changelog]   - Model BlobNfsTarget has a new parameter write_back_timer
      info	[Changelog]   - Model Nfs3Target has a new parameter verification_timer
      info	[Changelog]   - Model Nfs3Target has a new parameter write_back_timer
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Renamed operation CachesOperations.update to CachesOperations.begin_update
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.StorageCache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.StorageCache/Debug/netstandard2.0/Azure.ResourceManager.StorageCache.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Azure.ResourceManager.StorageCache.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/storagecache/armstoragecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Operation `*CachesClient.Update` has been changed to LRO, use `*CachesClient.BeginUpdate` instead.
      info	[Changelog] - Struct `CloudError` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*StorageTargetsClient.BeginRestoreDefaults(context.Context, string, string, string, *StorageTargetsClientBeginRestoreDefaultsOptions) (*runtime.Poller[StorageTargetsClientRestoreDefaultsResponse], error)`
      info	[Changelog] - New struct `StorageTargetsClientRestoreDefaultsResponse`
      info	[Changelog] - New field `VerificationTimer` in struct `BlobNfsTarget`
      info	[Changelog] - New field `WriteBackTimer` in struct `BlobNfsTarget`
      info	[Changelog] - New field `VerificationTimer` in struct `Nfs3Target`
      info	[Changelog] - New field `WriteBackTimer` in struct `Nfs3Target`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 5 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-storagecache [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation Caches.beginUpdate
      info	[Changelog]   - Added operation Caches.beginUpdateAndWait
      info	[Changelog]   - Added operation StorageTargets.beginRestoreDefaults
      info	[Changelog]   - Added operation StorageTargets.beginRestoreDefaultsAndWait
      info	[Changelog]   - Added Interface CachesDebugInfoHeaders
      info	[Changelog]   - Added Interface CachesDeleteHeaders
      info	[Changelog]   - Added Interface CachesFlushHeaders
      info	[Changelog]   - Added Interface CachesStartHeaders
      info	[Changelog]   - Added Interface CachesStopHeaders
      info	[Changelog]   - Added Interface CachesUpdateHeaders
      info	[Changelog]   - Added Interface CachesUpgradeFirmwareHeaders
      info	[Changelog]   - Added Interface StorageTargetFlushHeaders
      info	[Changelog]   - Added Interface StorageTargetInvalidateHeaders
      info	[Changelog]   - Added Interface StorageTargetResumeHeaders
      info	[Changelog]   - Added Interface StorageTargetsDeleteHeaders
      info	[Changelog]   - Added Interface StorageTargetsDnsRefreshHeaders
      info	[Changelog]   - Added Interface StorageTargetsRestoreDefaultsHeaders
      info	[Changelog]   - Added Interface StorageTargetsRestoreDefaultsOptionalParams
      info	[Changelog]   - Added Interface StorageTargetSuspendHeaders
      info	[Changelog]   - Interface BlobNfsTarget has a new optional parameter verificationTimer
      info	[Changelog]   - Interface BlobNfsTarget has a new optional parameter writeBackTimer
      info	[Changelog]   - Interface CachesUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface CachesUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface Nfs3Target has a new optional parameter verificationTimer
      info	[Changelog]   - Interface Nfs3Target has a new optional parameter writeBackTimer
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation Caches.update
      info	[Changelog]   - Operation Caches.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation Caches.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation StorageTargets.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation StorageTargets.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Interface CachesCreateOrUpdateOptionalParams no longer has parameter cache
      info	[Changelog]   - Interface StorageTargetsCreateOrUpdateOptionalParams no longer has parameter storagetarget
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️storagecache [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from de600b90f1364aa89fc801215783e321be2a3059. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.storagecache [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/storagecache/armstoragecache https://apiview.dev/Assemblies/Review/4fb2fed7a62645828cfc948ffde57a32
    Java azure-resourcemanager-storagecache https://apiview.dev/Assemblies/Review/f8bbc774ff034caabf111cfd70a7979d
    .Net Azure.ResourceManager.StorageCache https://apiview.dev/Assemblies/Review/8f9c277878c64e7a878795d1774f070d
    JavaScript @azure/arm-storagecache https://apiview.dev/Assemblies/Review/fcb0e9778df34dbda3ed8bd0958b01f2

    /azp run unifiedPipeline

    brpanask avatar Oct 12 '22 19:10 brpanask

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 12 '22 19:10 azure-pipelines[bot]

    /azp run unifiedPipeline

    brpanask avatar Oct 18 '22 04:10 brpanask

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 18 '22 04:10 azure-pipelines[bot]

    /azp run unifiedPipeline

    brpanask avatar Oct 18 '22 17:10 brpanask

    No pipelines are associated with this pull request.

    azure-pipelines[bot] avatar Oct 18 '22 17:10 azure-pipelines[bot]

    @brpanask - Please fix the checks, set your PR to Open, and apply the WaitForARMFeedback label if/when you are ready for ARM review. If you no longer need this PR, please close it.

    mentat9 avatar Jan 05 '23 02:01 mentat9

    Hi @brpanask, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Hi, @brpanask, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    },
    

    Common parameters best practice - use common types There are definitions of common parameters in commontypes types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:3497 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    },
    

    This looks like its based on the standard ARM SKUs contract? If so I wonder if we can get this included in common-types definitions


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:3101 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    },
    

    I think I see you using this to declare resource ids - but resource ids aren't really fully qualified URLs - they are just absolute paths


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:3145 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    "/subscriptions/{subscriptionId}/providers/Microsoft.StorageCache/locations/{location}/ascOperations/{operationId}": {
    

    Are you using this to implement the Azure-AsyncOperation header pattern, here?

    https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#azure-asyncoperation-resource-format

    If so, the usual name for this resource type would be something like operationsStatuses.


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:161 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

              "$ref": "#/definitions/CloudError"
    

    Error responses - use common types There are definitions of error responses and details in commontypes types.json that you can use instead of declaring your own. See e.g. ErrorResponse https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L300 And ErrorDetail https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#LL258C21-L258C21


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:198 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

          },
    

    Best practice - Location parameters - use common types There are definitions of common parameters in commontypes types.json that you can use instead of declaring your own, like LocationParameter, which is useful for modeling locations/{locationName} in paths like ARM location-based routing scenarios. See https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L657


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:179 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

          }
    

    Best practice - OperationId parameters - Common parameters best practice - use common types There are definitions of common parameters in commontypes types.json that you can use by $ref instead of declaring your own, like SubscriptionIdParameter, OperationIdParameter, and ApiVersionParameter, See https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L630


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:186 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    "/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.StorageCache/caches/{cacheName}/spaceAllocation": {
    

    post actions should be a verb. E.g. 'getSpaceAllocation' or 'changeAllocation' or just 'reallocate'

    But also, I wonder if you could model this as a PUT or PATCH action on the cache, in case it is a pretty straightforward ideally idempotent 'write' or 'update' to the cache description (plus some side effects).


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:1729 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    },
    

    Best practice - don't declare these yourself, just reuse common-types

    OperationListResult - use common types The OperationListResult type is defined correctly in commontypes types.json. It is recommended to reference and reuse the common definition instead of declaring your own. [Otherwise it is frequently declared incorrectly.]

                "schema": {
                  "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/OperationListResult"
                }
    

    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:1950 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    },
    

    Best practice - don't declare error responses and operation status results yourself, just reuse common types

    Error responses - use common types There are definitions of error responses and details in commontypes types.json that you can use instead of declaring your own. See e.g. ErrorResponse https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L300 And ErrorDetail and OperationStatusResult


    In reply to: 1382660355


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:1987 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

    },
    

    Best practice - don't declare these yourself, just reuse common types's OperationStatusResult:

    https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v3/types.json#L418


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:2036 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

        },
    

    Best practice - Instead of declaring all these, inherit (allOf) common-types TrackedResource.

    Instead of defining your own resource class with required top level properties, 'id', 'type', 'name', and 'location' and 'tags' (for TrackedResource) its recommended to inherit from ProxyResource or TrackedResource in common-types v2 or v3.json. (The v2 definition does NOT include systemData, and is otherwise similar to the v3 one). https://github.com/Azure/azure-rest-api-specs/blob/be6cd9ccfcb6ba08c1c206627026eabfbff31fc1/specification/common-types/resource-management/v3/types.json#L56


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:2092 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

                "Cancelled",
    

    spell Canceled with one L, to match the RPC spec


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:2130 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith

              "description": "Array of IP addresses that can be used by clients mounting this Cache.",
    

    Are both IPv4 and IPv6 supported?


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/preview/2023-03-01-preview/storagecache.json:2118 in 3bd573a. [](commit_id = 3bd573abcfb2dcc84bdfd24b2c8da8699538e442, deletion_comment = False)

    TimLovellSmith avatar Jan 14 '23 04:01 TimLovellSmith