azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Published
20 hours ago •
Azure
Azure
[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- [ ] SDK of .NET (need service team to ensure code readiness)
- [ ] SDK of Python
- [ ] SDK of Java
- [ ] SDK of Js
- [ ] SDK of Go
- [ ] PowerShell
- [ ] CLI
- [ ] Terraform
- [ ] No refresh required for updates in this PR
Contribution checklist:
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
- [ ] Removing API(s) in a stable version
- [ ] Removing properties in a stable version
- [ ] Removing API version(s) in a stable version
- [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.
Hi, @mitagarg Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 9 Errors, 1 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
|
The response of operation:'Exports_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L98 |
|
The response of operation:'Exports_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L160 |
|
The response of operation:'Views_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L118 |
|
The response of operation:'Views_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L155 |
|
The response of operation:'Views_GetByScope' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L246 |
|
The response of operation:'Views_CreateOrUpdateByScope' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L286 |
|
The response of operation:'Alerts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L440 |
|
The response of operation:'Alerts_Dismiss' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L483 |
|
The schema 'ForecastDataset' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L2166 |
| :warning: R2018 - XmsEnumValidation | The enum types should have x-ms-enum type extension set with appropriate options. Property name: direction Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1286 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L270 |
|
The response schema of operations API '/providers/Microsoft.CostManagement/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1103 |
|
The schema 'ReportConfigDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L396 |
|
The schema 'ReportConfigTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L438 |
|
The schema 'ReportConfigDataset' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L457 |
|
The schema 'ReportConfigDatasetConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L507 |
|
The schema 'ReportConfigAggregation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L519 |
|
The schema 'ReportConfigSorting' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L543 |
|
The schema 'ReportConfigGrouping' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L563 |
|
The schema 'ReportConfigFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L580 |
|
The schema 'ReportConfigComparisonExpression' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L625 |
|
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L669 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L684 |
|
The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.exports.json#L713 |
|
The schema 'ReportConfigDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1136 |
|
The schema 'ReportConfigTimePeriod' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1178 |
|
The schema 'ReportConfigDataset' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1197 |
|
The schema 'ReportConfigDatasetConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1247 |
|
The schema 'ReportConfigAggregation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1259 |
|
The schema 'ReportConfigSorting' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1283 |
|
The schema 'ReportConfigGrouping' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1303 |
|
The schema 'ReportConfigFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1320 |
|
The schema 'ReportConfigComparisonExpression' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1365 |
|
The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1568 |
|
The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1593 |
|
The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1622 |
|
The schema 'DismissAlertPayload' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L1999 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L2062 |
|
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L2089 |
|
The schema 'ForecastDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.CostManagement/stable/2021-10-01/costmanagement.json#L2111 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 6 Errors, 14 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.0)
- current:stable/2021-10-01/costmanagement.exports.json compared with base:stable/2021-01-01/costmanagement.exports.json
- current:stable/2021-10-01/costmanagement.exports.json compared with base:preview/2020-12-01-preview/costmanagement.exports.json
- current:stable/2021-10-01/costmanagement.json compared with base:stable/2020-06-01/costmanagement.json
- current:stable/2021-10-01/costmanagement.json compared with base:preview/2019-04-01-preview/costmanagement.json
The following breaking changes are detected by comparison with latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"cost-management/resource-manager/readme.md", "tag":"package-2021-10", "details":"Error: Plugin prechecker reported failure." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.
Swagger Generation Artifacts
️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-costmanagement - 3.0.0+ Model ExportExecution no longer has parameter tags + Model QueryFilter no longer has parameter dimensions + Model QueryFilter no longer has parameter tags + Model QueryResult no longer has parameter e_tag + Model QueryResult no longer has parameter location + Model QueryResult no longer has parameter sku + Model ReportConfigFilter no longer has parameter dimensions + Model ReportConfigFilter no longer has parameter tag_key + Model ReportConfigFilter no longer has parameter tag_value + Model ReportConfigFilter no longer has parameter tags + Model View no longer has parameter currency + Model View no longer has parameter data_set + Model View no longer has parameter date_range + Model View no longer has parameter include_monetary_commitment + Operation ExportsOperations.get has a new signature + Operation ExportsOperations.list has a new signature + Removed operation group GenerateReservationDetailsReportOperations + Removed operation group SettingsOperations
️✔️azure-sdk-for-go - costmanagement/mgmt/2021-01-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - costmanagement/mgmt/2020-06-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - costmanagement/mgmt/2019-11-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - costmanagement/mgmt/2019-10-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - costmanagement/mgmt/2019-01-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - costmanagement/mgmt/2018-05-31/costmanagement - v57.4.0️✔️azure-sdk-for-go - preview/costmanagement/mgmt/2019-03-01/costmanagement - v57.4.0️✔️azure-sdk-for-go - preview/costmanagement/mgmt/2018-08-01-preview/costmanagement - v57.4.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 0aa79a0df2ef1b57eeba311327883fd94c394ada. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/cost-management/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.CostManagement [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 0aa79a0df2ef1b57eeba311327883fd94c394ada. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️costmanagement/mgmt/2021-01-01/costmanagement [View full logs] [Preview SDK Changes]info [Changelog] This is a new package
️✔️costmanagement/mgmt/2020-06-01/costmanagement [View full logs]info [Changelog] No exported changes
️✔️costmanagement/mgmt/2019-11-01/costmanagement [View full logs]info [Changelog] No exported changes
️✔️costmanagement/mgmt/2019-10-01/costmanagement [View full logs]info [Changelog] No exported changes
️✔️costmanagement/mgmt/2019-01-01/costmanagement [View full logs]info [Changelog] No exported changes
️✔️costmanagement/mgmt/2018-05-31/costmanagement [View full logs]info [Changelog] No exported changes
️✔️preview/costmanagement/mgmt/2019-03-01/costmanagement [View full logs]info [Changelog] No exported changes
️✔️preview/costmanagement/mgmt/2018-08-01-preview/costmanagement [View full logs]info [Changelog] No exported changes
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 0aa79a0df2ef1b57eeba311327883fd94c394ada. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-costmanagement [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Model QueryFilter has a new parameter dimension info [Changelog] - Model QueryFilter has a new parameter not_property info [Changelog] - Model QueryFilter has a new parameter tag info [Changelog] - Model ExportExecution has a new parameter error info [Changelog] - Model ExportExecution has a new parameter e_tag info [Changelog] - Model View has a new parameter dataset info [Changelog] - Model CommonExportProperties has a new parameter run_history info [Changelog] - Model CommonExportProperties has a new parameter next_run_time_estimate info [Changelog] - Model Export has a new parameter run_history info [Changelog] - Model Export has a new parameter next_run_time_estimate info [Changelog] - Model ExportProperties has a new parameter run_history info [Changelog] - Model ExportProperties has a new parameter next_run_time_estimate info [Changelog] - Model ReportConfigFilter has a new parameter dimension info [Changelog] - Model ReportConfigFilter has a new parameter not_property info [Changelog] - Model ReportConfigFilter has a new parameter tag info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Operation ExportsOperations.get has a new signature info [Changelog] - Operation ExportsOperations.list has a new signature info [Changelog] - Model QueryFilter no longer has parameter tags info [Changelog] - Model QueryFilter no longer has parameter dimensions info [Changelog] - Model ExportExecution no longer has parameter tags info [Changelog] - Model View no longer has parameter data_set info [Changelog] - Model View no longer has parameter date_range info [Changelog] - Model View no longer has parameter currency info [Changelog] - Model View no longer has parameter include_monetary_commitment info [Changelog] - Model QueryResult no longer has parameter location info [Changelog] - Model QueryResult no longer has parameter e_tag info [Changelog] - Model QueryResult no longer has parameter sku info [Changelog] - Model ReportConfigFilter no longer has parameter tags info [Changelog] - Model ReportConfigFilter no longer has parameter dimensions info [Changelog] - Model ReportConfigFilter no longer has parameter tag_key info [Changelog] - Model ReportConfigFilter no longer has parameter tag_value info [Changelog] - Removed operation group GenerateReservationDetailsReportOperations info [Changelog] - Removed operation group SettingsOperations
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 0aa79a0df2ef1b57eeba311327883fd94c394ada. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
Hi @mitagarg, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.
| Task | How to fix | Priority | Support (Microsoft alias) |
|---|---|---|---|
| Avocado | Fix-Avocado | High | ruowan |
| Semantic validation | Fix-SemanticValidation-Error | High | raychen, jianyxi |
| Model validation | Fix-ModelValidation-Error | High | raychen,jianyxi |
| LintDiff | Fix-LintDiff | high | jianyxi, ruoxuan |