azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[ElasticSan] Add new module Az.ElasticSan

Open yifanz0 opened this issue 3 years ago • 5 comments

Description

First preview release for module Az.ElasticSan. Cmdlets added include:

  • Add-AzElasticSanVolumeGroupNetworkRule
  • Get-AzElasticSan
  • Get-AzElasticSanSkuList
  • Get-AzElasticSanVolume
  • Get-AzElasticSanVolumeGroup
  • New-AzElasticSan
  • New-AzElasticSanVirtualNetworkRuleObject
  • New-AzElasticSanVolume
  • New-AzElasticSanVolumeGroup
  • Remove-AzElasticSan
  • Remove-AzElasticSanVolume
  • Remove-AzElasticSanVolumeGroup
  • Remove-AzElasticSanVolumeGroupNetworkRule
  • Update-AzElasticSan
  • Update-AzElasticSanVolume
  • Update-AzElasticSanVolumeGroup

Design link: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1265

Checklist

  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

yifanz0 avatar Sep 21 '22 03:09 yifanz0

/azp run

blueww avatar Sep 21 '22 03:09 blueww

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 21 '22 03:09 azure-pipelines[bot]

/azp run

wyunchi-ms avatar Sep 21 '22 06:09 wyunchi-ms

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 21 '22 06:09 azure-pipelines[bot]

@wyunchi-ms The CI seems to be still failing with the build errors. Could you please help take a look to see if you have any idea about this? Thanks a lot :)

WARNING: Both Az and AzureRM modules were detected on this machine. Az and AzureRM modules cannot be imported in the same session or used in the same script or runbook. If you are running PowerShell in an environment you control you can use the 'Uninstall-AzureRm' cmdlet to remove all AzureRm modules from your machine. If you are running in Azure Automation, take care that none of your runbooks import both Az and AzureRM modules. More information can be found here: https://aka.ms/azps-migration-guide

  Directory: D:\a\1\s\artifacts

Mode LastWriteTime Length Name


d---- 9/21/2022 6:50 AM autorest

D:\a\1\s\build.proj(125,5): error MSB3073: The command "pwsh -NonInteractive -NoLogo -NoProfile -Command "D:\a\1\s\tools/PrepareAutorestModule.ps1"" exited with code 1. ##[error]Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

yifanz0 avatar Sep 21 '22 09:09 yifanz0