azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Add new parameter ASN, Geo, ExpressrouteAdvertise to New-AzCustomIpPrefix command

Open gitlwh opened this issue 3 years ago • 1 comments

Description

We need to add new parameter ASN, Geo, ExpressrouteAdvertise to New-AzCustomIpPrefix command. Also make a small change to make noInternetAdvertise nullable. Which was done in a earlier PR for same version. There is no breaking change in the PR. We are passing latest SDK version to resolve some syntax error. https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1268

Checklist

  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

gitlwh avatar Sep 20 '22 23:09 gitlwh

Commenter does not have sufficient privileges for PR 19532 in repo Azure/azure-powershell

azure-pipelines[bot] avatar Sep 20 '22 23:09 azure-pipelines[bot]

wait for the release of SDK

wyunchi-ms avatar Sep 22 '22 04:09 wyunchi-ms

/azp run azure-powershell - security-tools

wyunchi-ms avatar Sep 23 '22 06:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 23 '22 06:09 azure-pipelines[bot]

@wyunchi-ms can you please help to merge that? I can't do it due to permissions restrictions...

MikhailTryakhov avatar Sep 23 '22 20:09 MikhailTryakhov

/azp run azure-powershell - security-tools

wyunchi-ms avatar Sep 26 '22 00:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 26 '22 00:09 azure-pipelines[bot]