azure-powershell
azure-powershell copied to clipboard
[AppService]: fix #17347- Fixed `Import-AzWebAppKeyVaultCertificate` to use certificate naming convention same as Az-CLI
Description
#17347
When using the Import-AzWebAppKeyVaultCertificate, the Microsoft.Web\Certificates created use the name standard "Keyvalt-Secret" to import the certificate.
In case there are multiple App Service Plans from different webspace on the same RG, the 1st import will work fine and can be used by the App Service Plan. Now, if you run the same import to another ASP that is on a different Webspace, it will be understood as an update of the 1st certificate and the App Service Plan won't be able to consume the certificate.
Azure CLI (az webapp config ssl import) imports with the standard "webspace+KeyVaultName+CertName" and that way it is difficult to conflict with the same name.
Please use the same standard or allow to create it's own name
Checklist
- [ ] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:
- SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to
generationbranch. - SHOULD make the title of PR clear and informative, and in the present imperative tense.
- SHOULD update
ChangeLog.mdfile(s) appropriately- For any service, the
ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md - A snippet outlining the change(s) made in the PR should be written under the
## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch. - Should not change
ChangeLog.mdif no new release is required, such as fixing test case only.
- For any service, the
- SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
- SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
- SHOULD have proper test coverage for changes in pull request.
- SHOULD NOT introduce breaking changes in Az minor release except preview version.
- SHOULD NOT adjust version of module manually in pull request
/azp run azure-powershell - security-tools
Azure Pipelines successfully started running 1 pipeline(s).
Hi Kota, please read the checklist in PR description and check the checkbox. Thank you.
Hi Kota, please read the checklist in PR description and check the checkbox. Thank you.
Done!