azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[Az.RecoveryServices] Fix for GetAzRecoveryServicesVaultSettingsFile cmdlet

Open vidyadharijami opened this issue 3 years ago • 1 comments
trafficstars

Description

Fix for GetAzRecoveryServicesVaultSettingsFile cmdlet. It includes change in the way vault cred file being generated.

Checklist

  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

vidyadharijami avatar Aug 05 '22 10:08 vidyadharijami

@isra-fel Please review this change as we need this ASAP as it's related to security hot fix.

I am working on fixing tests.

vidyadharijami avatar Aug 10 '22 08:08 vidyadharijami

@isra-fel Please review.

vidyadharijami avatar Aug 16 '22 11:08 vidyadharijami

/azp run azure-powershell - security-tools

isra-fel avatar Aug 17 '22 06:08 isra-fel

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 17 '22 06:08 azure-pipelines[bot]