azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Generate 2022 04 01 desktopvirtualization

Open ryanosh opened this issue 3 years ago • 3 comments
trafficstars

Description

generated powershell modules for desktopvirtualization api version 2022-04-01-preview and updated modules and tests for scalingplan and scalingplanpooledschedule accordingly

Checklist

  • [ X] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

ryanosh avatar Aug 01 '22 22:08 ryanosh

Please also resolve the conflicts to unblock CI.

isra-fel avatar Aug 17 '22 02:08 isra-fel

Kindly ping @ryanosh

isra-fel avatar Aug 29 '22 06:08 isra-fel

Please resolve the conflicts. @ryanosh

wyunchi-ms avatar Sep 06 '22 03:09 wyunchi-ms

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀

isra-fel avatar Jan 10 '23 07:01 isra-fel