Added Delete Option for Set-AzVmssStorageProfile and Add-AzVmssDataD…

[pselugar]

trafficstars

…isk cmdlets

Description

Please find the Design request here

• https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1176

Checklist

• [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
• SHOULD make the title of PR clear and informative, and in the present imperative tense.
• SHOULD update ChangeLog.md file(s) appropriately
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
  • Create new module from the scratch
  • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
  • Create new resource type which name doesn't use module name as prefix
  • Have design question before implementation
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT introduce breaking changes in Az minor release except preview version.
• SHOULD NOT change version of module in pull request

[grizzlytheodore]

could you add powershell design to the description?

[grizzlytheodore]

please update description for this PR and add powershell design link

[pselugar]

could you add powershell design to the description?

Added powershell design to the description

[pselugar]

please update description for this PR and add powershell design link

Updated

[grizzlytheodore]

LGTM @isra-fel could you review/merge?

[isra-fel]

Again, my question is about the inconsistency of parameter names: *Delete*Option vs. OsDisk*Deletion*Option. They may cause some confusion for customers. Which one is more formal? Can you use one word for both parameters?

Also please resolve the conflicts.

[pselugar]

I find it a little confusing that one parameter is called *Delete*Option while another is OsDisk*Deletion*Option. Is there any particular reason they are different?

Regarding this, the naming conventions *Delete*Option and OsDisk*Deletion*Option are defined in the PR design itself (https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1176).

I followed the PR design in naming conventions, can you please have a look at design?

For clarity- DeleteOption- refers to Data Disk deletion OsDiskDeletionOption - Delete Os Disk profile

[isra-fel]

@pselugar Hi, I checked the design and it read OsDiskDeleteOption (rather than "Deletion"). So please correct the name of this parameter. Don't forget to refresh the documents. Thanks.

[pselugar]

@pselugar Hi, I checked the design and it read OsDiskDeleteOption (rather than "Deletion"). So please correct the name of this parameter. Don't forget to refresh the documents. Thanks.

Thanks for the catch. Made the changes and generated corresponding .md files.

[isra-fel]

/azp run azure-powershell - security-tools

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).