azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

Added --skip-npm-install option for NodeJS V4 programming model

Open AlexPshul opened this issue 2 years ago • 2 comments

Issue describing the changes in this PR

This really helps in mono-repo scenarios in which the NPM install is not actually needed but takes a significant time to initialize a new project. (A proper warning is added if NPM installation is skipped) resolves #3332

Pull request checklist

  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [x] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [x] I have added all required tests (Unit tests, E2E tests)

AlexPshul avatar Jun 03 '23 15:06 AlexPshul

@microsoft-github-policy-service agree

AlexPshul avatar Jun 03 '23 15:06 AlexPshul

Hi @khkh-ms @mattchenderson , Is there anything else I need to do in this PR? Or is it ready for merging?

AlexPshul avatar Mar 20 '24 14:03 AlexPshul

/azp run

khkh-ms avatar Apr 30 '24 15:04 khkh-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 30 '24 15:04 azure-pipelines[bot]

Hi @khkh-ms thank you for continuing the process on this. I see that the build failed on 2 items and it seems to be unrelated to my changes:

  • Azure.Functions.Cli.Tests.E2E.InitTests.init_with_Dockerfile(workerRuntime: "node", version: "4")
  • Azure.Functions.Cli.Tests.E2E.DeploymentTests.RemoteBuildPythonFunctionApp

Is it something I need to handle on my side? Is there anything I can help with to help with the merge?

AlexPshul avatar May 02 '24 18:05 AlexPshul