autorest.typescript icon indicating copy to clipboard operation
autorest.typescript copied to clipboard

Should we have prettier and formatting commands in generated non-azure projects

Open jeremymeng opened this issue 1 year ago • 1 comments

We have the following now. The questions is whether we want to include "prettier" as a dev dependency and the two formatting scripts in non-AzureMonorepo packages.

If we almost always re-generate code, it then makes sense to let codegen format the generated code, without needing scripts that customer would run manually.

metadata/packageJson/buildAzureMonorepoPackage.ts:204:      'dev-tool run vendored prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \
"src/**/*.{ts,cts,mts}" "test/**/*.{ts,cts,mts}" "*.{js,cjs,mjs,json}"',
metadata/packageJson/buildAzureMonorepoPackage.ts:211:      'dev-tool run vendored prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore "src/**/*\
.{ts,cts,mts}" "test/**/*.{ts,cts,mts}" "*.{js,cjs,mjs,json}"',
metadata/packageJson/buildFlavorlessPackage.ts:43:      'prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore "src/**/*.ts" "*.{js,json}\
" ',
metadata/packageJson/buildAzureStandalonePackage.ts:85:      'prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore "src/**/*.ts" "*.{js,\
json}"  "test/**/*.ts" "samples-dev/**/*.ts"',
metadata/packageJson/buildAzureStandalonePackage.ts:89:      'prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore "src/**/*.ts" "*.{js,json}"  "\
test/**/*.ts" "samples-dev/**/*.ts"',

jeremymeng avatar Jul 24 '24 14:07 jeremymeng

I think we prefer to not generate prettier for non azure.

qiaozha avatar Jul 31 '24 08:07 qiaozha