ResourceModules icon indicating copy to clipboard operation
ResourceModules copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Fix `winrm` listeners data type

Open coolhome opened this issue 1 year ago • 7 comments
trafficstars

Description

winRM is passed to listeners, which is an array and not an object. I was not able to perform set-module on the virtual machine construct, that template is broken.

Pipeline references

Pipeline

Type of Change

  • [X] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [X] Update to documentation

Checklist

  • [X] I'm sure there are no other open Pull Requests for the same update/change
  • [ ] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [X] My code follows the style guidelines of this project
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation (readme)
  • [X] I did format my code

coolhome avatar Dec 19 '23 19:12 coolhome

Hey @coolhome, the construct template definitely is. It's essentially just code we parked when initially migrating all modules from ARM to Bicep. In the future setup with AVM, it would be considered a pattern. I think the reason we did not outright delete it was that it contains logic to generate x amount of VM names for the deploying person.

AlexanderSehr avatar Dec 19 '23 20:12 AlexanderSehr

@rahalan, note this update may be relevant for the AVM VM PR. However, @coolhome could it be the encoding or something similar was changed? The files appears completely new which makes it very hard to sport what actually changed.

AlexanderSehr avatar Dec 19 '23 20:12 AlexanderSehr

@AlexanderSehr yah I just noticed that as well. I have core.autocrlf=false and I think this is the root cause.

image This is not really a solution but a way to see the differences without the newline issue.

Let me know if you want to re-create the PR. I am also happy with whatever.

coolhome avatar Dec 19 '23 20:12 coolhome

Closing since its now implemented in https://github.com/Azure/bicep-registry-modules/pull/717 for AVM.

coolhome avatar Dec 20 '23 17:12 coolhome

Hey @coolhome, may I ask you to re-open the PR? I think for VMSS this is still very much relevant, isn't it? This module isn't migrated yet / started.

AlexanderSehr avatar Dec 20 '23 17:12 AlexanderSehr