ms-identity-javascript-angular-tutorial icon indicating copy to clipboard operation
ms-identity-javascript-angular-tutorial copied to clipboard

Update 3.1 to follow BASHER and Zero Trust guidelines

Open derisen opened this issue 3 years ago • 4 comments

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

derisen avatar Jul 06 '22 17:07 derisen

Angular single-page application using MSAL Angular to sign-in users with Azure Active Directory and call a .NET Core web API

nit:An Angular SPA using MSAL Angular to sign-in users with Azure Active Directory and call a protected .NET Core web API


In reply to: 1182140157


In reply to: 1182140157


Refers to: 3-Authorization-II/1-call-api/README.md:1 in 4a60819. [](commit_id = 4a608195002fd51d5c5b6f842b617246ef1fff5b, deletion_comment = False)

kalyankrishna1 avatar Jul 12 '22 18:07 kalyankrishna1

this is an outdated link


In reply to: 1182164196


In reply to: 1182164196


Refers to: 3-Authorization-II/1-call-api/README.md:40 in 4a60819. [](commit_id = 4a608195002fd51d5c5b6f842b617246ef1fff5b, deletion_comment = False)

kalyankrishna1 avatar Jul 12 '22 18:07 kalyankrishna1

  • A user account in your Azure AD tenant. This sample will not work with a personal Microsoft account. Therefore, if you signed in to the Azure portal with a personal account and have never created a user account in your directory before, you need to do that now.

add tow lines,

  1. get latest NPM
  2. get latest .NET core

In reply to: 1182223110


In reply to: 1182223110


Refers to: 3-Authorization-II/1-call-api/README.md:41 in 4a60819. [](commit_id = 4a608195002fd51d5c5b6f842b617246ef1fff5b, deletion_comment = False)

kalyankrishna1 avatar Jul 12 '22 18:07 kalyankrishna1

Aside from a couple of nits LGTM 👍

v-michaelmi avatar Jul 12 '22 19:07 v-michaelmi