azure-spring-boot-samples icon indicating copy to clipboard operation
azure-spring-boot-samples copied to clipboard

Combinig cosmos db samples

Open M-Lipin opened this issue 2 years ago • 1 comments

Purpose

This PR solves the issue #577.

Does this introduce a breaking change?

[ ] Yes [x] No

Pull Request Type

The change is a refactoring: combining two Azure spring boot samples (for AKS and a regular one) into one sample.

[ ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [x] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other... Please describe:

How to Test

  • Need to review readme files and try Azure spring boot sample with AKS and without it.
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid Readme files for Azure spring boot samples.

Other Information

There were some differences between AKS and non-AKS Azure spring boot samples. Need to verify that the change does not break anything.

M-Lipin avatar Jul 05 '23 16:07 M-Lipin

@M-Lipin Please take a look at the case where the check fails, thanks.

Netyyyy avatar Jul 13 '23 01:07 Netyyyy