azure-search-openai-demo icon indicating copy to clipboard operation
azure-search-openai-demo copied to clipboard

do not add local path to file as url

Open tuggeluk opened this issue 3 weeks ago • 1 comments

Purpose

Listfile strategy adds the local filepath to the URL field of listfilestrategy.File. This causes all file uploads to blob storage to be skipped, which breaks the file viewer feature of the citation.

Simply leaving the field empty fixes the issue for me - I am unaware of any side-effects of this simple fix. But I am also not deeply familiar with all aspects of this project.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[ x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial, check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ x] No

Type of change

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • [ x] The current tests all pass (python -m pytest).
  • [ does not apply] I added tests that prove my fix is effective or that my feature works
  • [ x] I ran python -m pytest --cov to verify 100% coverage of added lines
  • [ x] I ran python -m mypy to check for type errors
  • [ x] I either used the pre-commit hooks or ran ruff and black manually on my code.

tuggeluk avatar Nov 05 '25 10:11 tuggeluk

Thank you for the PR! I am currently making a large change to ingestion in order to support cloud-based ingestion, I will review this PR after.

pamelafox avatar Nov 10 '25 21:11 pamelafox

works!

bf-2026 avatar Nov 19 '25 03:11 bf-2026