Set public network access to deny and allow azure network access

[tonybaloney]

This is a breaking change since the old template would allow any public IP to try and connect to the deployed Keyvault environment..

https://microsoft.sharepoint.com/teams/AzureTenantBaseline2/SitePages/Key-Vault-must-have-public-access-disabled.aspx (Internal) reference on this security policy

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[ ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial, check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

• [ ] The current tests all pass (python -m pytest).
• [ ] I added tests that prove my fix is effective or that my feature works
• [ ] I ran python -m pytest --cov to verify 100% coverage of added lines
• [ ] I ran python -m mypy to check for type errors
• [ ] I either used the pre-commit hooks or ran ruff and black manually on my code.

[pamelafox]

Won't this break local development for folks using free search service tier, as they need to access key vault to get the key?

[jongio]

@tonybaloney - Can you also PR this back to azure-dev?

[pamelafox]

Obsolete