azure-digital-twins-unreal-integration icon indicating copy to clipboard operation
azure-digital-twins-unreal-integration copied to clipboard

fix ms graph migration breaking changes

Open jaredholloway94 opened this issue 3 years ago • 4 comments

Purpose

Fix /deployment/scripts/deploy.ps1 to comply with the new Microsoft Graph version of the Azure CLI.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

jaredholloway94 avatar Aug 09 '22 20:08 jaredholloway94

CLA assistant check
All CLA requirements met.

ghost avatar Aug 09 '22 20:08 ghost

Hi Jared,

I attempted a new deployment with your pull request but that failed. I am not too sure what is happening. Kindly help. Screenshot 2022-09-01 171248

kofiasare266 avatar Sep 19 '22 16:09 kofiasare266

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue?

deployment_error.txt deployment_error_azure.txt

nkronqvist avatar Oct 08 '22 10:10 nkronqvist

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue?

deployment_error.txt deployment_error_azure.txt

Hi Nils, the plugin is broken. I am told it is being fixed. So fingers crossed.

kofiasare266 avatar Oct 12 '22 12:10 kofiasare266

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue? deployment_error.txt deployment_error_azure.txt

Hi Nils, the plugin is broken. I am told it is being fixed. So fingers crossed.

Hi everyone,

Is there any update on this issue?

also if someone could respond with examples of what repo-adress, repo-name and branch-name should look like (be replaced with) so i know what i should be looking for.

many thanks, DT

digitaltriplets avatar Nov 08 '22 15:11 digitaltriplets

I urgently need an update to this.. also facing the same issue

vararth avatar Nov 10 '22 08:11 vararth

Great changes! Apologies for the lack of movement on this repo, I am in the process of taking care of this repository.

I am running through a quick check to solve some of the issues on this repo, and this solves a few of them. I will reply to the relevant issues located in the larger repo once an end-end deployment has been confirmed.

Merging these changes in.

adamlash avatar Nov 22 '22 23:11 adamlash

Hello All on this PR,

I have recently made some more changes in a newer PR fixing up a few bugs and issues related to this repo. Feel free to try this again and see if you get the expected outputs.

Any issues? Feel free to open an issue and I'll get to it ASAP

adamlash avatar Nov 23 '22 00:11 adamlash

image Oops....I just tried it ! There is still an error

niagara1120 avatar Nov 24 '22 00:11 niagara1120