azure-ad-workload-identity icon indicating copy to clipboard operation
azure-ad-workload-identity copied to clipboard

docs: remove unnecessary config lines

Open krukowskid opened this issue 1 year ago • 2 comments

Purpose

Hey @paolosalvatori, thank you for this content! I have removed azure.workload.identity/use: "true" from code samples, because its not valid for service account https://azure.github.io/azure-workload-identity/docs/topics/service-account-labels-and-annotations.html#service-account

I have also removed azure.workload.identity/tenant-id: ${tenantId} annotation because it defaults to tenantId value set during wi installation.

    helm install $releaseName $repoName/$chartName \
        --namespace $namespace \
        --create-namespace \
        --set azureTenantID="$tenantId"

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

krukowskid avatar Nov 22 '23 20:11 krukowskid

@microsoft-github-policy-service agree

krukowskid avatar Nov 22 '23 21:11 krukowskid

Thanks @krukowskid, I wrote the article when the Workload Identity was still in preview, so in the meantime, a few things have changed, and I missed refreshing the sample. 😸

paolosalvatori avatar Nov 23 '23 08:11 paolosalvatori