active-directory-aspnetcore-webapp-openidconnect-v2 icon indicating copy to clipboard operation
active-directory-aspnetcore-webapp-openidconnect-v2 copied to clipboard

Sentence duplicate in the README.MD

Open anniex325 opened this issue 5 years ago • 1 comments

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

The issue was found for the following scenario:

Please add an 'x' for the scenario(s) where you found an issue

  1. Web app that signs in users
    1. [ ] with a work and school account in your organization: 1-WebApp-OIDC/1-1-MyOrg
    2. [ ] with any work and school account: /1-WebApp-OIDC/1-2-AnyOrg
    3. [ ] with any work or school account or Microsoft personal account: 1-WebApp-OIDC/1-3-AnyOrgOrPersonal
    4. [ ] with users in National or sovereign clouds 1-WebApp-OIDC/1-4-Sovereign
    5. [ ] with B2C users 1-WebApp-OIDC/1-5-B2C
  2. Web app that calls Microsoft Graph
    1. [ ] Calling graph with the Microsoft Graph SDK: 2-WebApp-graph-user/2-1-Call-MSGraph
    2. [ ] With specific token caches: 2-WebApp-graph-user/2-2-TokenCache
    3. [ ] Calling Microsoft Graph in national clouds: 2-WebApp-graph-user/2-4-Sovereign-Call-MSGraph
  3. [ ] Web app calling several APIs 3-WebApp-multi-APIs
  4. [x] Web app calling your own Web API 4-WebApp-your-API
  5. Web app restricting users
    1. [ ] by Roles: 5-WebApp-AuthZ/5-1-Roles
    2. [ ] by Groups: 5-WebApp-AuthZ/5-2-Groups
  6. [ ] Deployment to Azure
  7. [ ] Other (please describe)

Repro-ing the issue

Repro steps In README-incremental-instructions.md under 4-1-MyOrg, the sentences: in Admin consent display name type Access TodoListService-aspnetcore-webapi as a user in Admin consent description type Accesses the TodoListService-aspnetcore-webapi Web API as a user in User consent display name type Access TodoListService-aspnetcore-webapi as a user in User consent description type Accesses the TodoListService-aspnetcore-webapi Web API as a user

Possible Solution

in Admin consent display name type Access TodoListService-aspnetcore-webapi as an admin in Admin consent description type Accesses the TodoListService-aspnetcore-webapi Web API as an admin _in User consent display name type Access TodoListService-aspnetcore-webapi as an user in User consent description type Accesses the TodoListService-aspnetcore-webapi Web API as an user

Additional context/ Error codes / Screenshots

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?) Windows 10

Versions

of ASP.NET Core, of MSAL.NET ASP.NET Core 3.1

Mention any other details that might be useful


Thanks! We'll be in touch soon.

anniex325 avatar Mar 19 '20 01:03 anniex325

@anniex325, actually the message is the same, it's just that it's addressed either to the user, or to an admin. It would be better to say

  • " the app can access the web api on your behalf" (in the case of the user consent)
  • " the app can access the web api on behalf users in the tenant" (in the case of the admin consent)

jmprieur avatar Nov 30 '20 14:11 jmprieur

Issue resolved with commit 391863

Closing.

v-michaelmi avatar Sep 07 '22 17:09 v-michaelmi