SpeechToText-WebSockets-Javascript icon indicating copy to clipboard operation
SpeechToText-WebSockets-Javascript copied to clipboard

Add Custom Speech integration to SDK and sample

Open mikebranstein opened this issue 7 years ago • 16 comments

The SDK did not previously allow for testing of the Custom Speech service using the Speech WebSocket protocol. This adds an option to select the Bing Speech API or the Custom Speech API. It uses the new Custom Speech API endpoint URLs, published after //BUILD 2018.

mikebranstein avatar May 18 '18 15:05 mikebranstein

CLA assistant check
All CLA requirements met.

msftclas avatar May 18 '18 15:05 msftclas

If there is no changes in package.json, there should be no changes in package-lock.json.

If their package-lock.json is outdated for some reasons, should split this change into another PR focusing on that topic.

The PR looks great IMO.

compulim avatar Jun 30 '18 23:06 compulim

Thank you, @compulim. I've corrected the package-lock.json issue, removing my unintended changes.

mikebranstein avatar Jul 03 '18 12:07 mikebranstein

Can you close this PR ASAP? We need the custom endpoint

mattiagecchele avatar Jul 12 '18 10:07 mattiagecchele

+1

unsafecode avatar Jul 12 '18 10:07 unsafecode

Hello @mikebranstein @compulim is there any reason this PR is not completed yet? It is blocking using the new unified speech service in bot framework WebChat, right? I hope you can follow up on this internally with the team to look into it and complete it.

tjoudeh avatar Sep 15 '18 00:09 tjoudeh

@tjoudeh I am not the owner of this repo and not a member of Cognitive Services team, so I cannot approve/merge this PR. 😔 I also hope to see it coming in asap.

compulim avatar Sep 16 '18 05:09 compulim

@tjoudeh I am also not the owner, nor Microsoft. I work for a MSFT partner that has been using this extensively, so I'd love to see the changes merged.

Perhaps @RaviPidaparthi could help us find the owner.

mikebranstein avatar Sep 19 '18 13:09 mikebranstein

@zhouwangzw Could you please check?

msimecek avatar Sep 20 '18 07:09 msimecek

Any news??? @WSturman. It's possible to merge this?

npacucci avatar Oct 17 '18 12:10 npacucci

@WSturman , @mikebranstein any news?? why this is not being merged?

vippatel90 avatar Oct 23 '18 06:10 vippatel90

@viananth I am not the owner of this repo, and not a Microsoft employee. I cannot merge, unfortunately. @WSturman and @wolfma61 - perhaps you can facilitate this merge. It looks like you've made the most recent commits.

mikebranstein avatar Oct 23 '18 13:10 mikebranstein

Can we get this merged please?

EricDahlvang avatar Nov 07 '18 22:11 EricDahlvang

This sample is for Bing Speech, which is retiring. We have a JavaScript sample for the new Speech Service at https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/js/browser.

WSturman avatar Nov 07 '18 23:11 WSturman

@WSturman Hi. I was wondering how to implement the endpoint from cris.ai for my custom speech. There is method SpeechConfig.fromEndpoint which accepts a url and subscription key, but there is no mention from where we can get that url. Is it the websocket URL, or REST url?

Kartik1607 avatar Nov 28 '18 06:11 Kartik1607

@Kartik1607 - I think you're looking for the REST endpoints listed in the Swagger Spec: https://westus.cris.ai/swagger/ui/index. Please select v2 from the drop-down, as the details you're looking for may not be available in Beta.

erhopf avatar Nov 28 '18 16:11 erhopf