pw-viz icon indicating copy to clipboard operation
pw-viz copied to clipboard

Support cycles

Open minijackson opened this issue 4 years ago • 5 comments
trafficstars

Hello and thank you for this project, it looks great!

The only issue I've seen so far from my very limited testing, is that pw-viz does not support cycles. The usecase I had was using Ardour, an audio work station:

I have a session with two tracks (Top and Bottom in the screenshot), whose audio is routed to the Master bus, and the Master bus is then forwarded to the speakers.

Here's how it looks in Patchage:

screenshot

In pw-viz, the message ERROR [pw_viz::ui::graph] Cycle detected is displayed on the terminal. Here's how it looks:

20211117_19h10m28s_grim

Thanks again!

minijackson avatar Nov 17 '21 18:11 minijackson

I see the same thing with Ardour as well.

skryking avatar Nov 17 '21 20:11 skryking

Calfjackhost also exposes all plugins as one node, which necessitates looping back to the same node (patchage):

image

jansol avatar Nov 18 '21 14:11 jansol

I made some changes in the grouped_nodes branch, nodes with cycles seem to be working, although cyclic graphs as a whole are not supported yet image

Ax9D avatar Nov 18 '21 17:11 Ax9D

Nice! May I suggest making the link curves protrude from the ports a bit more aggressively? They turn behind the nodes rather quickly now, if they made a slightly bigger loop before disappearing that might help with readability a bit. Also if it's easily possible to make the nodes slightly transparent without hurting the readability that would help with following links that pass behind nodes.

jansol avatar Nov 18 '21 18:11 jansol

Support for cycles was added in 415a619, although i'll keep this issue open till the next release

Ax9D avatar Jan 02 '22 13:01 Ax9D