taipy
taipy copied to clipboard
Avaiga
Have the possibility for filtering in Taipy table to be case insensitive
Description This will add the possibility to choose whether the filter is case-sensitive or not in Taipy tables (when the filter is on).
Acceptance Criteria
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%
- [ ] Propagate any change on the demos and run all of them to ensure there is no breaking change
- [ ] Ensure any change is well documented
All taipy filtering mechanisms should apply this new feature and have a similar UX.
New Quest!
A new Quest has been launched in @Avaiga’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.
Some loot has been stashed in this issue to reward the solver!
🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!
⚔️ When you submit a PR, comment @quest-bot loot #426 to link your PR to this Quest.
Questions? Check out the docs.
![quest-bot[bot] avatar](https://avatars.githubusercontent.com/in/378551?v=4 "Published by a pub.dev verified publisher"){kind=small}
@NILAY1556 has embarked on their Quest. 🗡
- @NILAY1556 has been on GitHub since 2023.
- They have merged 0 public PRs in that time.
- Their swords are blessed with
HTMLandCSSmagic ✨ - They haven't contributed to this repo before.
This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.
Questions? Check out the docs.
@Surani02 is not working on this issue ...please can i have a Assignee on this issue @FlorianJacta
@FlorianJacta I tried to solve this issue as I could, but I couldn't solve it. Apologize for the inconvenience.
Hi @FlorianJacta @FredLL-Avaiga @jrobinAV , I would like to work on this issue, please assign this to me. I plan to introduce a configuration option allowing users to toggle between case-sensitive and case-insensitive filtering. However, I would appreciate some guidance on the following points:
- Could you please point me to the files responsible for handling the table filtering logic, both on the frontend and backend, so I can modify the comparison logic accordingly?
- Are there any specific configuration files or settings within the Taipy framework where this new option should be added to ensure smooth integration?
Given the similarities to the Alert component configuration , I believe this change will be straightforward once I locate the appropriate files. Your advice on this would be invaluable.
Thank you for your time and support!
@Rishi-0007 has embarked on their Quest. 🗡
- @Rishi-0007 has been on GitHub since 2021.
- They have merged 2 public PRs in that time.
- Their swords are blessed with
HTMLandTypeScriptmagic ✨ - They have contributed to this repo before.
This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.
Questions? Check out the docs.
Yes, go ahead, @Rishi-0007. Thank you for your contribution. I will let @FabienLelaquais or @FredLL-Avaiga answer you!
hey @FlorianJacta , i am working on it and also i commented before @Rishi-0007
or @Rishi-0007 , if you want to work on it together , please contact me i am a beginner and you also before work on this project so , here is my linkedin please message me bro : "https://www.linkedin.com/in/nilay-dhandhukiya-b81bab277/" , or mail me : "[email protected]"
or @Rishi-0007 , if you want to work on it together , please contact me i am a beginner and you also before work on this project so , here is my linkedin please message me bro : "https://www.linkedin.com/in/nilay-dhandhukiya-b81bab277/" , or mail me : "[email protected]"
I will suggest you to pick good first issue to get yourself familiar with Taipy repository.
okay , i'll sure and also if you want to , can you give me your any social links 'cause i didn't find any in your github account so i can connect with you that would be great
Yes, go ahead, @Rishi-0007. Thank you for your contribution. I will let @FabienLelaquais or @FredLL-Avaiga answer you!
Hey @FabienLelaquais @FredLL-Avaiga , I am waiting for your guidance to start working on this issue.
You can start Filter is done on the frontend in tableFilter.tsx and mainly in pandas_data_accessor.py in the backend
🧚 @Rishi-0007 has submitted PR https://github.com/Avaiga/taipy/issues/2087 and is claiming the loot.
Keep up the pace, or you'll be left in the shadows.
cc @NILAY1556
Questions? Check out the docs.
I think we need to discuss some spec on this. Here is my proposal:
- in the Table Filter UI, add a switch indicating case sensitive or not when the filter type is string
- add the information to the FilterDesc interface (proposed name
matchCase) - in the data_accessor, act accordingly depending on the FilterDesc property value
Let me know what you think @FlorianJacta @jrobinAV @FabienLelaquais @Rishi-0007
@FredLL-Avaiga I think that's great.
VSCode uses
which is a switch...
Do you know precisely where an equivalent icon would be located?
didn't find it in https://mui.com/material-ui/material-icons but I found a repo with some SVG https://github.com/mchaput/icons/blob/master/icon-case-sensitive.svg
This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}