taipy icon indicating copy to clipboard operation
taipy copied to clipboard

User theme (light or dark mode) should be an accessible variable

Open AlexandreSajus opened this issue 1 year ago • 10 comments

Description

A user on Discord requested this. The user's theme (light or dark mode) should be a callable variable within the code. This way, the dev could have different images displayed according to the current theme (a white background image in light mode and a black background image in dark mode)

Acceptance Criteria

  • [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
  • [ ] Create related issue in taipy-doc for documentation and Release Notes.
  • [ ] Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
  • [ ] Ensure any change is well documented.

Code of Conduct

  • [X] I have checked the existing issues.
  • [ ] I am willing to work on this issue (optional)

AlexandreSajus avatar Jul 08 '24 13:07 AlexandreSajus

would love to work on this @AlexandreSajus. can you assign me this issue?

ranjanmangla1 avatar Jul 11 '24 06:07 ranjanmangla1

@ranjanmangla1 The "Help wanted" and "good first issue" labels have been misused on this issue. The issue has not been validated nor discussed with the maintainer team, yet.

We will discuss it as soon as possible (probably tomorrow) and will let you know if the issue is ok to be assigned.

Thank you for your understanding.

jrobinAV avatar Jul 11 '24 17:07 jrobinAV

A priori, it will be implemented as a CSS rule. The documentation should provide an example.

jrobinAV avatar Jul 12 '24 13:07 jrobinAV

hey i would like to work on the issue

sOnU1002 avatar Oct 02 '24 17:10 sOnU1002

Hello @jrobinAV ,

I would like to work on this issue and help implement the theme-based image display functionality. My plan is to:

  • Ensure the user's theme (light or dark mode) is stored as a variable in the code.
  • Implement conditional logic to switch between light and dark mode images.
  • Write unit tests to achieve at least 90% code coverage.
  • Document the changes in taipy-doc and consider updating or creating a demo based on this.

Could you please assign this issue to me? Thank you!

PayalKumari10 avatar Oct 02 '24 18:10 PayalKumari10

hey, I would like to work on this issue. You can assign this to me. Thanks

sangram-mkj-01 avatar Oct 03 '24 06:10 sangram-mkj-01

I will assign @sOnU1002 as it was the first reply. Thank you for your contribution!

@PayalKumari10, @sangram-mkj-01, there are a lot of issues to take!

FlorianJacta avatar Oct 03 '24 07:10 FlorianJacta

can u please specify wherei have add the code

sOnU1002 avatar Oct 03 '24 07:10 sOnU1002

@FabienLelaquais will know which people in R&D you should talk to

FlorianJacta avatar Oct 03 '24 07:10 FlorianJacta

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1492 to link your PR to this Quest.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 07 '24 11:10 quest-bot[bot]

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

github-actions[bot] avatar Oct 22 '24 09:10 github-actions[bot]

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

github-actions[bot] avatar Nov 06 '24 09:11 github-actions[bot]

@FlorianJacta Should i work on it

sanketshinde3001 avatar Nov 08 '24 09:11 sanketshinde3001