taipy icon indicating copy to clipboard operation
taipy copied to clipboard

Pipenv is too slow. Shift to a faster package manager.

Open anunayasri opened this issue 1 year ago • 14 comments

Description I want to contribute to taipy codebase and am setting up the code in my local. pipenv install took minutes to setup the dependencies. I suggest to shift to a faster dependency manager like pdm. pdm can import Pipfile from the project and generate a pyproject.toml file that it uses. I think shifting to pdm is easier.

Files to be added to the repo:

  • pyproject.toml
  • pdm.lock
  • pdm.toml

.pdm-python will be generated and should not be committed. It is to be added to .gitignore.

Acceptance Criteria

  • [ ] Ensure all uses for pipenv is configured for pdm including local setup & running tests.
  • [ ] Ensure documents are updated.

anunayasri avatar Apr 10 '24 09:04 anunayasri

I can pick it up if maintainers are fine with shifting to pdm.

anunayasri avatar Apr 10 '24 09:04 anunayasri

We are reviewing your request internally.

FlorianJacta avatar Apr 22 '24 09:04 FlorianJacta

Please assign me this issue. Thank you @FlorianJacta.

Also, Is this reviewed internally as you mentioned above?

Prathamesh010 avatar Oct 03 '24 14:10 Prathamesh010

I think it was discussed in another thread that taipy repo will be on Pipenv. As of Oct 3, 2024, the pipenv install is still super slow on my laptop. It gets stuck in the 'Locking' phase. pdm took 10min to install the the deps in a fresh virtual env.

I think we can close this issue for now. I will try to write the steps of using pdm in a gist or discussion and will share. Hopefully, it will the contributors who are unhappy with pipenv.

anunayasri avatar Oct 03 '24 17:10 anunayasri

Assigned

AlexandreSajus avatar Oct 04 '24 13:10 AlexandreSajus

@anunayasri Can you please link the thread? or @FredLL-Avaiga and @FabienLelaquais Can you please confirm if this is still relevant or we can close this issue?

Prathamesh010 avatar Oct 05 '24 10:10 Prathamesh010

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1149 to link your PR to this Quest.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 07 '24 11:10 quest-bot[bot]

The relevant thread: https://github.com/Avaiga/taipy/issues/1151#issuecomment-2388313722 @Prathamesh010

@AlexandreSajus I think this issue can be closed.

anunayasri avatar Oct 07 '24 11:10 anunayasri

I have used to use pdm and uv for dependency management in my local. I have listed the steps here: https://github.com/Avaiga/taipy/discussions/1955

anunayasri avatar Oct 07 '24 18:10 anunayasri

I’m eager to contribute to this issue

Sahiltripathy005 avatar Oct 09 '24 02:10 Sahiltripathy005

We'll review the state of this issue with @jrobinAV and @FabienLelaquais

FlorianJacta avatar Oct 09 '24 12:10 FlorianJacta

@FlorianJacta FYI. There is a parallel discussion that happened in https://github.com/Avaiga/taipy/issues/1151. @FabienLelaquais has few comments there. I have partially solved the issue for myself and listed the steps in https://github.com/Avaiga/taipy/discussions/1955. I would love to solve it permanently. My related comment shifting regarding shifting to uv https://github.com/Avaiga/taipy/issues/1151#issuecomment-2397638508

anunayasri avatar Oct 10 '24 05:10 anunayasri

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

github-actions[bot] avatar Oct 24 '24 09:10 github-actions[bot]

@FlorianJacta is this resolved? If not can you assign it to me?

muhammedsafuvan avatar Oct 26 '24 11:10 muhammedsafuvan

@FlorianJacta is this issue resolved, if not I would like to work on it.

Yashwanth-Chandrakumar avatar Oct 29 '24 13:10 Yashwanth-Chandrakumar

@muhammedsafuvan @Yashwanth-Chandrakumar Both of you have been assigned. Do not hesitate to submit your Pull Requests, or to collaborate on a unique PR.

jrobinAV avatar Oct 31 '24 13:10 jrobinAV