Colin Roberts
Colin Roberts
Can we make this a tracking issue and have sub issues? Also, I think we really only need a bigint -- we can just wrap `PrimeField` around our bigint once...
@mrdaybird thoughts on: - removing `PrimeField` as `GaloisField` for prime `P` accomplishes the same thing? - Renaming `FiniteGroup` to `Group` - Removing `Finite` altogether? - Removing `MultiplicativeFiniteGroup`? I feel that...
Good catch @mrdaybird, I think we should leave both `GaloisField` and `PrimeField` not only for ease, but for the inverse as you called it. However, with proper specialization in Rust...
@mrdaybird still interested in this? Would love to remove `crypto-bigint` dependency as it is preventing updating to Rust 2024 and using newer versions of the toolchain. Of course, no pressure....
@mrdaybird you're a champ
@mahmudsudo see #133 Maybe we can help carry that across, or at least use some of it moving forward. Check that PR out and let me know what you think.
Completed!
classic scary sounding thing for "take two things make new unique new thing"|
I want to push this up the list of TODOs. This is a really cool problem. @jtriley2p do you still have interest in this?
I read this and weeped. Both tears of joy, and real tears of being called out for the pedant I am. > _mathematicians_ Hurt... > pedantic jargon and deeply refined...