wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Stepper: Spike on domains step

Open escapemanuele opened this issue 3 years ago • 1 comments

Proposed Changes

This is just a test to see whether it is possible to bring the Domains step from /start to Stepper.

Things missing:

  • We still save step result with submitSignupStep and rely on the dependency store. This could be brought to the onboarding store, but I think it will need work on plans and checkout step as well. This can be maybe thought as an intermediate step?
  • use-your-domain page (/start/newsletter/domains/use-your-domain). Rendered based on stepSectionName, shouldn't be difficult to integrate. image
  • Management of queryObject, should be easy to get values from url params. Values have been set to default values for testing.

Testing Instructions

Pre-merge Checklist

  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?

Related to #

escapemanuele avatar Sep 22 '22 08:09 escapemanuele

Link to live branch is being generated... Please wait a few minutes and refresh this page.

github-actions[bot] avatar Sep 22 '22 08:09 github-actions[bot]

Work is here https://github.com/Automattic/wp-calypso/pull/68722

escapemanuele avatar Nov 15 '22 14:11 escapemanuele