wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

READER - Card Refresh

Open davemart-in opened this issue 3 years ago • 6 comments

Proposed Changes

The following PR comprises a handful of related issues, including:

  • [x] #66626
  • [x] #66623
  • [x] #66624
  • [x] #66625
  • [x] #66622
  • [x] #66618
  • [x] #67166
  • [x] #66619
  • [x] #66621
  • [x] #67564
  • [x] #66620

The goal being to update the visual design of all reader cards.

Before

Here's an example of what the reader card looked like before these changes:

CleanShot 2022-08-17 at 10 39 07

After

Here's what they will look like after:

CleanShot 2022-08-17 at 10 40 35

davemart-in avatar Aug 17 '22 14:08 davemart-in

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2220 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +7010 B  (+0.2%)    +2259 B  (+0.2%)
entry-main                  -438 B  (-0.0%)     -125 B  (-0.0%)
entry-gutenboarding         -298 B  (-0.0%)      -71 B  (-0.0%)
entry-domains-landing       -298 B  (-0.1%)      -71 B  (-0.0%)
entry-browsehappy           -298 B  (-0.3%)      -71 B  (-0.2%)
entry-login                 -237 B  (-0.0%)      -56 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4778 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
reader                              +12291 B  (+2.1%)    +4251 B  (+2.5%)
site-blocks                          -1051 B  (-0.3%)     -805 B  (-0.7%)
home                                  +120 B  (+0.0%)      +43 B  (+0.0%)
settings-writing                      -105 B  (-0.0%)    -1086 B  (-0.5%)
sites-dashboard                        +91 B  (+0.0%)      +34 B  (+0.0%)
settings                               +91 B  (+0.0%)      +26 B  (+0.0%)
security                               +91 B  (+0.0%)      +35 B  (+0.0%)
purchases                              +91 B  (+0.0%)      +37 B  (+0.0%)
privacy                                +91 B  (+0.0%)      +35 B  (+0.0%)
plugins                                +91 B  (+0.0%)      +23 B  (+0.0%)
people                                 +91 B  (+0.0%)      +26 B  (+0.0%)
notification-settings                  +91 B  (+0.0%)      +35 B  (+0.0%)
media                                  +91 B  (+0.0%)      +30 B  (+0.0%)
me                                     +91 B  (+0.0%)      +35 B  (+0.0%)
jetpack-cloud-plugin-management        +91 B  (+0.0%)      +27 B  (+0.0%)
jetpack-cloud-partner-portal           +91 B  (+0.0%)      +22 B  (+0.0%)
jetpack-cloud-agency-dashboard         +91 B  (+0.0%)      +21 B  (+0.0%)
import                                 +91 B  (+0.0%)      +26 B  (+0.0%)
help                                   +91 B  (+0.0%)      +35 B  (+0.0%)
happychat                              +91 B  (+0.0%)      +35 B  (+0.0%)
email                                  +91 B  (+0.0%)      +19 B  (+0.0%)
earn                                   +91 B  (+0.0%)      +23 B  (+0.0%)
domains                                +91 B  (+0.0%)      +19 B  (+0.0%)
activity                               +91 B  (+0.0%)      +25 B  (+0.0%)
account-close                          +91 B  (+0.0%)      +35 B  (+0.0%)
account                                +91 B  (+0.0%)      +35 B  (+0.0%)
posts-custom                           +76 B  (+0.0%)      +38 B  (+0.0%)
posts                                  +76 B  (+0.0%)      +38 B  (+0.0%)
pages                                  +76 B  (+0.0%)      +37 B  (+0.0%)
woocommerce-installation               +61 B  (+0.0%)      +13 B  (+0.0%)
woocommerce                            +61 B  (+0.0%)      +13 B  (+0.0%)
site-purchases                         +61 B  (+0.0%)      +13 B  (+0.0%)
settings-security                      +61 B  (+0.0%)      +13 B  (+0.0%)
settings-performance                   +61 B  (+0.0%)      +13 B  (+0.0%)
settings-jetpack                       +61 B  (+0.0%)      +13 B  (+0.0%)
settings-discussion                    +61 B  (+0.0%)      +13 B  (+0.0%)
scan                                   +61 B  (+0.0%)      +13 B  (+0.0%)
purchase-product                       +61 B  (+0.0%)      +14 B  (+0.0%)
plans                                  +61 B  (+0.0%)      +13 B  (+0.0%)
migrate                                +61 B  (+0.0%)      +13 B  (+0.0%)
marketplace                            +61 B  (+0.0%)      +13 B  (+0.0%)
marketing                              +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-social                         +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-search                         +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-connect                        +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud-settings                 +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud-pricing                  +61 B  (+0.0%)      +13 B  (+0.0%)
jetpack-cloud                          +61 B  (+0.0%)      +13 B  (+0.0%)
hosting                                +61 B  (+0.0%)      +13 B  (+0.0%)
gutenberg-editor                       +61 B  (+0.0%)      +13 B  (+0.0%)
google-my-business                     +61 B  (+0.0%)      +13 B  (+0.0%)
export                                 +61 B  (+0.0%)      +13 B  (+0.0%)
customize                              +61 B  (+0.0%)      +13 B  (+0.0%)
concierge                              +61 B  (+0.0%)      +13 B  (+0.0%)
comments                               +61 B  (+0.0%)      +13 B  (+0.0%)
checkout                               +61 B  (+0.0%)      +13 B  (+0.0%)
backup                                 +61 B  (+0.0%)      +13 B  (+0.0%)
add-ons                                +61 B  (+0.0%)      +13 B  (+0.0%)
themes                                 +47 B  (+0.0%)      +22 B  (+0.0%)
stats                                  +46 B  (+0.0%)      +17 B  (+0.0%)
promote-post                           +46 B  (+0.0%)      +22 B  (+0.0%)
devdocs                                -44 B  (-0.0%)      -13 B  (-0.0%)
theme                                  +17 B  (+0.0%)       +4 B  (+0.0%)
preview                                +17 B  (+0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1911 bytes added 📈 [gzipped])

name                                                         parsed_size           gzip_size
async-load-design-blocks                                        +13391 B  (+0.6%)    +3958 B  (+0.7%)
async-load-calypso-components-web-preview-component              +7492 B  (+1.3%)    +2391 B  (+1.4%)
async-load-calypso-reader-feed-stream                            +1126 B  (+3.8%)     +433 B  (+4.6%)
async-load-calypso-reader-search-stream                          +1030 B  (+1.2%)     +267 B  (+1.1%)
async-load-calypso-reader-site-stream                             +987 B  (+3.3%)     +382 B  (+4.0%)
async-load-calypso-reader-sidebar                                 +688 B  (+0.4%)      +69 B  (+0.2%)
async-load-calypso-blocks-support-article-dialog-dialog           -682 B  (-0.6%)     -250 B  (-0.7%)
async-load-automattic-help-center                                 -591 B  (-0.1%)     -356 B  (-0.2%)
async-load-calypso-blocks-reader-full-post                        +395 B  (+0.9%)     +175 B  (+1.4%)
async-load-calypso-reader-following-manage                        +368 B  (+0.3%)      +75 B  (+0.2%)
async-load-calypso-reader-list-manage                             +186 B  (+0.5%)      +44 B  (+0.4%)
async-load-calypso-reader-tag-stream-main                         +182 B  (+1.3%)      +45 B  (+1.0%)
async-load-calypso-reader-list-stream                             +182 B  (+1.2%)      +46 B  (+1.0%)
async-load-signup-steps-theme-selection                            +91 B  (+0.1%)      +24 B  (+0.1%)
async-load-signup-steps-p2-complete-profile                        +91 B  (+0.1%)      +24 B  (+0.0%)
async-load-design-playground                                       +91 B  (+0.0%)      +23 B  (+0.0%)
async-load-design                                                  +91 B  (+0.0%)      +23 B  (+0.0%)
async-load-signup-steps-site-picker                                +61 B  (+0.0%)      +13 B  (+0.0%)
async-load-signup-steps-plans-atomic-store                         +61 B  (+0.0%)      +19 B  (+0.0%)
async-load-signup-steps-plans                                      +61 B  (+0.0%)      +18 B  (+0.0%)
async-load-signup-steps-difm-site-picker                           +61 B  (+0.0%)      +13 B  (+0.0%)
async-load-signup-steps-clone-point                                +61 B  (+0.0%)      +15 B  (+0.0%)
async-load-signup-steps-clone-destination                          +61 B  (+0.1%)      +16 B  (+0.1%)
async-load-signup-steps-clone-credentials                          +61 B  (+0.0%)      +18 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                         +61 B  (+0.0%)      +16 B  (+0.0%)
async-load-calypso-layout-guided-tours-component                   +61 B  (+0.1%)      +17 B  (+0.1%)
async-load-calypso-components-sites-popover                        +61 B  (+0.0%)      +13 B  (+0.0%)
async-load-calypso-blocks-legal-updates-banner                     +61 B  (+1.4%)      +15 B  (+0.9%)
async-load-calypso-blocks-inline-help-popover                      +61 B  (+0.0%)      +13 B  (+0.0%)
async-load-signup-steps-design-picker                              -44 B  (-0.0%)      -10 B  (-0.0%)
async-load-calypso-my-sites-site-settings-seo-settings-form        -44 B  (-0.0%)      -11 B  (-0.0%)
async-load-calypso-blocks-support-article-dialog                   -44 B  (-1.5%)      -13 B  (-1.1%)
async-load-calypso-post-editor-editor-media-modal                  +30 B  (+0.0%)      +15 B  (+0.0%)
async-load-calypso-layout-masterbar-drafts-popover                 +29 B  (+0.1%)      +20 B  (+0.2%)
async-load-calypso-reader-p-2-main                                 -22 B  (-0.7%)      -16 B  (-1.5%)
async-load-calypso-reader-conversations-stream                     -22 B  (-0.5%)      -10 B  (-0.6%)
async-load-calypso-reader-a-8-c-main                               -22 B  (-0.7%)      -16 B  (-1.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Aug 17 '22 14:08 matticbot

We'll have to look at the way that very long tags wrap. It's currently looking quite cramped with the reduced width and the hamburger menu on top. The tags are just getting cropped off at the moment. cc @ollierozdarz @davemart-in Screen Shot 2022-08-24 at 11 56 33 am

roo2 avatar Aug 24 '22 01:08 roo2

@roo2 we've got an issue to move them to their own line and apply a bit of styling: #66622

Should be an easy one.

davemart-in avatar Aug 24 '22 02:08 davemart-in

@roo2 this is how we've defined tags to be styled going forward:

image

ollierozdarz avatar Aug 25 '22 04:08 ollierozdarz

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/reader-card-refresh on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

matticbot avatar Aug 25 '22 08:08 matticbot