wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

[TeamCity][Sentry] Add a `SENTRY_RELEASE_NAME` param to the GB source-map uploader build

Open fullofcaffeine opened this issue 3 years ago • 5 comments
trafficstars

Proposed Changes

WPCOM will soon start creating a Sentry release for each deploy (see the related section below for more contextual info). We were using a fixed wpcom-test-01 release for testing purposes so far, and it was also used in this build to upload source-map files for the Gutenberg on WPCOM. We now need to pass the dynamic release name, and for that, we need to add a new param to the build. The consuming script* will then pass the release name in this param.

*Right now, the consuming script is gutenbot that will trigger this build after installing a new version of Gutenberg on WPCOM. This is done in D85487-code

Testing Instructions

  • Checks should pass
  • After merging, the right param should be part of the build in TC

Pre-merge Checklist

  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?

Related to:

  • https://github.com/Automattic/wp-calypso/pull/63260
  • https://github.com/Automattic/wp-calypso/pull/66186
  • D85265-code
  • D85487-code

fullofcaffeine avatar Aug 05 '22 17:08 fullofcaffeine

Nice! What's the plan for supporting other plugins like ETK? Will those also be integrated into this script eventually?

noahtallen avatar Aug 05 '22 20:08 noahtallen

Nice! What's the plan for supporting other plugins like ETK? Will those also be integrated into this script eventually?

Yep, I think we'll do the same for ETK* et al, following the same pattern of having a build (or a single build, maybe integrate them all in one) for them!

*Right now, source-maps for ETK are served alongside the js assets, but this makes the fetching by Sentry prone to networking errors.

fullofcaffeine avatar Aug 05 '22 21:08 fullofcaffeine

following the same pattern of having a build (or a single build, maybe integrate them all in one) for them!

👍 I think it could also be possible to store ETK source maps as a TeamCity artifact, and then download them in, say, this build. That might save us some time!

noahtallen avatar Aug 05 '22 21:08 noahtallen

This should be merged only after the changes in D85265-code and D85487-code are pushed.

fullofcaffeine avatar Aug 10 '22 17:08 fullofcaffeine

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Aug 11 '22 21:08 matticbot