php-thrift-sql icon indicating copy to clipboard operation
php-thrift-sql copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

supprt Hive's table schema

Open wxiaoguang opened this issue 5 years ago • 1 comments
trafficstars

wxiaoguang avatar Dec 05 '19 08:12 wxiaoguang

In fact, I have made a big refactor to ThriftSQL ( https://github.com/wxiaoguang/php-thrift-sql )

The major problem is that the Iterator design pattern is not quite good.

My changes:

  • clean all prefix underline in property/method names.
  • code re-format
  • re-design the Query / Iterator pattern
  • more clear exception mechanism
  • disallow re-run an executed query
  • remove QueryCleaner. (the user should take care about the statement, not the framework)

If you feel that the refactor is OK, I can polish it and submit P-R again.

If the refactor may cause problem with the official one, I can submit separated patches.

wxiaoguang avatar Dec 05 '19 16:12 wxiaoguang