Add evaluation form to Welcome Flow

[robertsreberski]

Proposed changes:

• Add Evaluation step with checkbox form
• Add Evaluation "Loader" step (with timeout, currently)
• Integrate Evaluation with Welcome Banner flow

Other information:

• [ ] Have you written new tests for your changes, if applicable?
• [ ] Have you checked the E2E test CI results, and verified that your changes do not break them?
• [ ] Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Create a JN site with Jetpack Beta add/welcome-banner-survey branch selected
• In My Jetpack, notice that you have a Welcome Banner presented
• Connect the site, and notice that the next step is Evaluation form
• After submitting the form - you should see "Evaluation processing" screen for around 3 seconds (mocked operation which will be addressed in the following PR) - after that the Welcome Banner will disappear

[github-actions[bot]]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• :white_check_mark: Include a description of your PR changes.
  
• :white_check_mark: Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• :white_check_mark: Add testing instructions.
  
• :white_check_mark: Specify whether this PR includes any changes to data or privacy.
  
• :red_circle: Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation :robot:

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

:red_circle: Action required: Please add missing changelog entries for the following projects: projects/packages/my-jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add. Guidelines: /docs/writing-a-good-changelog-entry.md

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged. If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[github-actions[bot]]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/welcome-banner-survey branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/welcome-banner-survey
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[ilonagl]

Thank you for working on this, @robertsreberski!

Everything looks great; I’d only remove the red dot after they connect the site to Jetpack. Users did the main action we wanted them to do, and the onboarding survey is a secondary action.

[CodeyGuyDylan]

@robertsreberski One comment I wanted to make before this is merged, is it weird that a user can select 1-4 specific options AND "I don't know"? I feel as though the "I don't know" option shouldn't be able to be selected if any other options are selected. I guess in that case it wouldn't be able to be in the checkbox list, maybe a separate button next to "Skip onboarding" that defaults their answer to "I don't know"? Just a thought I had

[ilonagl]

@CodeyGuyDylan shared a valid thought! @robertsreberski, how does the logic of the current recommendations work re picking 'I don't know'? I wonder if we should disable this choice if other choices are selected to prevent the use case that Dylan shared?

[robertsreberski]

@CodeyGuyDylan shared a valid thought! @robertsreberski, how does the logic of the current recommendations work re picking 'I don't know'? I wonder if we should disable this choice if other choices are selected to prevent the use case that Dylan shared?

@ilonagl it currently adds points to promote specific products, as described in the table here: pbNhbs-aN2-p2

I was thinking that even if user selects that they want to improve the security of their website and "I don't know" option - we'll understand it as "I don't know what else I can improve on my website" and besides security products, promote also more general ones.

Because of that, currently you can select all checkboxes - I see it's worth re-considering from UX point of view. It's very easy to adjust the code to any option we'll decide to go with :)