Subway icon indicating copy to clipboard operation
Subway copied to clipboard

Off-By-One Error in Subgraph Generation

Open Jonathan-Rabideau opened this issue 3 years ago • 0 comments

On line 75 in subgraph_generator.cu, ceil() is useless with integer division. Should be unsigned int chunkSize = (unsigned int)ceil((double)numActiveNodes / numThreads);

Results in not copying some data to the edge array, sending the old values to the kernel which results in undefined behavior; usually erroneous values in the last .01% of the nodes (but can propagate through the rest of the graph).

Jonathan-Rabideau avatar Jun 09 '22 16:06 Jonathan-Rabideau