react-base-table icon indicating copy to clipboard operation
react-base-table copied to clipboard

Severe scroll lag

Open carielis opened this issue 2 years ago • 11 comments

https://github.com/Autodesk/react-base-table/assets/60296759/e398f59f-5cd7-4fae-9a73-c03d6d00126d

I don’t know what went wrong, but on macOS the lags look even worse, it’s also impossible to use on an office computer

carielis avatar Sep 06 '23 15:09 carielis

on macOS

https://github.com/Autodesk/react-base-table/assets/60296759/7d5ed105-8514-4d0e-9712-984fbce700a2

carielis avatar Sep 07 '23 08:09 carielis

i am facing the same problem ^

Uregek avatar Sep 07 '23 08:09 Uregek

fix this please

jellycattime avatar Sep 07 '23 08:09 jellycattime

Set same row height maybe result good performance~

xiaoxudoo avatar Sep 08 '23 06:09 xiaoxudoo

Set same row height maybe result good performance~

  • A little better, but not even close with react-window + sticky

carielis avatar Sep 09 '23 06:09 carielis

Set same row height maybe result good performance~

  • A little better, but not even close with react-window + sticky

yes, you can read the issue reply which write by the repo author: https://github.com/Autodesk/react-base-table/issues/3#issuecomment-894867194

which mentions: Thanks for the abandonment of IE(the only reason I used three tables to achieve frozen columns), those features could be accomplished in a super simple way and much better performance(using position: sticky)

I think the scroll lag is caused by using three table for fixed column. so maybe we can fixed it by using position: sticky; I'd like to try it...

xiaoxudoo avatar Sep 09 '23 14:09 xiaoxudoo

Set same row height maybe result good performance~

  • A little better, but not even close with react-window + sticky

yes, you can read the issue reply which write by the repo author: #3 (comment)

which mentions: Thanks for the abandonment of IE(the only reason I used three tables to achieve frozen columns), those features could be accomplished in a super simple way and much better performance(using position: sticky)

I think the scroll lag is caused by using three table for fixed column. so maybe we can fixed it by using position: sticky; I'd like to try it...

Do you happen to know the fork in which this is implemented?

carielis avatar Sep 10 '23 13:09 carielis

We defeated vertical scrolling by making sticky

https://github.com/Autodesk/react-base-table/assets/60296759/11b8b813-0064-4d3c-869d-47635614eb64

, but we don’t yet understand how to defeat headers

carielis avatar Sep 28 '23 11:09 carielis

@carielis How can sticky solve it?

lmcgit1 avatar Dec 19 '23 06:12 lmcgit1

@xiaoxudoo Do you happen to know the fork in which this is implemented?

lmcgit1 avatar Dec 20 '23 05:12 lmcgit1

@carielis How can sticky solve it?

We disabled fixedColumn and simply wrote our own solution, noting that column virtualization is missing from the react-base-table library

carielis avatar Jan 27 '24 07:01 carielis