enterprise-config-for-git icon indicating copy to clipboard operation
enterprise-config-for-git copied to clipboard

Make company configurable as far as possible

Open jokram opened this issue 8 years ago • 4 comments

Tried to make the code independent from Autodesk. So it should only depend on enterprice.constants.

  • Replaced "adsk" with "$KIT_ID" where possible
  • Replaced "Autodesk" with "GitHub Enterprise"
  • Replaced "ADS_USER" with "GHE_USER"
  • Replaced "ADS_PASSWORD_OR_TOKEN" with "GHE_PASSWORD_OR_TOKEN"

Exceptions:

  • config.include: Here I've not yet found a way to make this dependent on enterprise.constants
  • Readme.md: For another company the Readme should be adapted, because it is delivered to end users

Important Notes:

  • I've had a merge conflict on my test branch where I've already included feature/configurable-protocol So I've merged feature/configurable-protocol into this branch. Best is if you first check the other pull request https://github.com/Autodesk/enterprise-config-for-git/pull/7
  • I'm not yet able to test these changes, because there are other changes necessary before I can run it in my company environment:
    • JIRA link is different
    • Conventions for service account is different
    • Currently we are using SSH
    • Installation of LFS might fail due to proxy authentification
  • But I want to address these issues with separate pull requests

jokram avatar Jan 17 '17 08:01 jokram

@jokram : I haven't forgotten this PR. I am just super busy right now. This looks pretty good - I'll merge it ASAP. Are you blocked in any way?

larsxschneider avatar Jan 24 '17 12:01 larsxschneider

@larsxschneider: No problem. I'm still analyzing. Note: After merging the master branch further fixes are necessary before mering the pull request. I'll let you know when it make sense to review the changes (I need to push new commits with some fixes).

jokram avatar Jan 24 '17 12:01 jokram

OK. Sounds good! Don't hesitate to reach out to me if you run into any trouble with the enterprise-config-for-git setup.

larsxschneider avatar Jan 24 '17 13:01 larsxschneider

Concerning the proxy you might be right. But this will take a bit longer to understand, but it might be worth to avoid problems in the field.

I've created a DESIGN.md file to write down my analysis results. In addition this contains some design ideas you might have a look at (if the stress is decreasing a bit). But these ideas should be discussed first before continuing. Maybe it makes sense to cover this in a separate pull request or issue.

jokram avatar Jan 24 '17 17:01 jokram