linter-flow
linter-flow copied to clipboard
Relative path for better support for multiple projects
Hi i would like to use a relative path so that i can use
./node_modules/.bin/flow
in my projects.
executablePath: Absolute path to the Flow executable on your system.
From what i can see in it seems to be implemented. So maybe update the docs ?
The path would be relative to where your .flowconfig file is found... which may not be the project root. I'm not sure I really want to note all the complexities that could be affecting that in a setting description.
If you want to write something up for just the readme though send in a PR and I'd be happy to review it 😉.
As far as i can tell, the problem is that executablePath is not an absolute path, but in fact a relative path.
I think a fair bit of user pain could be saved by
- Changing the description of
exectuablePathto "relative path to your project's .flowconfig to your flow executable - Defaulting
executablePathtonode_modules/.bin/flow
I think this would also permanently solve the problem described in https://github.com/AtomLinter/linter-flow/issues/134.
As stated, if you want to submit a PR making those changes I can review + merge it.
Just a note, the text should be something like "An absolute path to `flow` or a relative path to `flow` from the project's `.flowconfig`."