linter-eslint icon indicating copy to clipboard operation
linter-eslint copied to clipboard

Published 20 hours ago • verified publisher icon AtomLinter

react-hooks/exhaustive-deps fix button

Open lambert-velir opened this issue 5 years ago • 2 comments

Issue Type

Bug/Feature Request

Issue Description

It seems that facebook disabled autofix for the react-hooks/exhaustive-deps rule. When I see this linter error, I see the error message, but I do not see a "fix" button, like I do for other linter errors:

Screen Shot 2020-06-04 at 4 27 59 PM

Other rules do have a "fix" button: Screen Shot 2020-06-04 at 4 29 09 PM

Is this something that needs to be added to linter-eslint? The facebook issue mentions the ESLint Suggestions API, so maybe this packages needs to be updated to use that?

lambert-velir avatar Jun 04 '20 20:06 lambert-velir

The rule needs to be fixable in order to see the fix button

UziTech avatar Mar 14 '21 07:03 UziTech

Hi @UziTech, this is a fixable rule in VS Code and it used to work in Atom. As I mentioned above, I think it's because the ESLint Suggestions API has changed. Can we update this package to support the react-hooks/exhaustive-deps fix button?

lambert-velir avatar Mar 15 '21 16:03 lambert-velir