node-ftps icon indicating copy to clipboard operation
node-ftps copied to clipboard

FIX: do not escape special characters on user and password

Open scipioa opened this issue 7 years ago • 4 comments

User and password fields are already between quotes: add the escape character '' gives wrong password or username.

scipioa avatar Aug 29 '18 13:08 scipioa

Hello @scipioa , this is a long shot since you posted this pull-request a few years ago, but are you still interested in applying this change? If you do might I suggest to use strong quoting?

MichielMag avatar Dec 10 '20 08:12 MichielMag

Hi @MichielMag , Yes, this change is still relevant. I don't really see the point of using strong quoting. This commit was used in production and worked fine.

scipioa avatar Apr 06 '21 09:04 scipioa

Hey Scipioa, thanks for responding! The reason I suggested strong quoting is because your fix only fixes one edge case. A problem like #81 would still happen. I think strong quoting tackles both issues.

MichielMag avatar Apr 07 '21 08:04 MichielMag

Open for a more agile solution

atinux avatar Mar 11 '22 14:03 atinux