lockdrop-ui icon indicating copy to clipboard operation
lockdrop-ui copied to clipboard

Published 20 hours ago • verified publisher icon AstarNetwork

fix: support EIP-1559

Open roy1210 opened this issue 4 years ago • 8 comments

  • add maxPriorityFeePerGas for writing contract function Demo: https://lockdrop-ui-beta-debp0tsiv-roy1210.vercel.app/#/lock-form

=Before=

roy1210 avatar Aug 27 '21 10:08 roy1210

Hi @bobo-kovacevic This is the deployed demo URL: https://lockdrop-ui-beta-debp0tsiv-roy1210.vercel.app/#/lock-form

Can you help to check with using the latest version of metamask (Supports EIP-1559) to call the contract function? I can't check it since the UI only allows to call the function by user who locked ETH long times ago. Also, please help to check if max priority fee has set as 2gwei.

It looks something like this but just 2gwei for max priority fee image

roy1210 avatar Sep 01 '21 07:09 roy1210

I've set maxPriorityFeePerGas as 2gwei as hard coding, but ideally get the value dynamically. I recommend to use blocknative API to get the latest maxPriorityFeePerGas. You can use this API with free account.

telegram-cloud-photo-size-5-6145464195139874319-y Usually I just get confidence: 80

roy1210 avatar Sep 01 '21 07:09 roy1210

Hi @hoonsubin @bobo-kovacevic Any update for this PR? Thanks!

roy1210 avatar Sep 06 '21 03:09 roy1210

Hi @roy1210 I apologize for late response. We will test the feature this week.

bobo-k2 avatar Sep 06 '21 05:09 bobo-k2

@roy1210 I tried to test your changes on my machine, but unfortunately this is not possible yet because of Ganache lacking London hardfork support. There is a PR to fix that https://github.com/trufflesuite/ganache/pull/1135. I will try again when they enable London support.

bobo-k2 avatar Sep 14 '21 04:09 bobo-k2

Hi @bobo-kovacevic

I tried to test your changes on my machine,

I see. Would you mind letting me reproduce this part on my machine? I'd like to debug if possible. My telegram ID: @Roy_Shoe_Kure

roy1210 avatar Sep 14 '21 05:09 roy1210

Hi @bobo-kovacevic The PR trufflesuite/ganache#1135 has been merged a while ago. Could you update, please?

roy1210 avatar Sep 24 '21 17:09 roy1210

Hi @bobo-kovacevic The PR trufflesuite/ganache#1135 has been merged a while ago. Could you update, please?

Hi @roy1210 thank you for update update about the PR. I will take a look. Also, I will contact you on Telegram regarding debugging

bobo-k2 avatar Sep 25 '21 11:09 bobo-k2