UnityFx.Outline icon indicating copy to clipboard operation
UnityFx.Outline copied to clipboard

Errors when running profiler

Open mihakrajnc opened this issue 4 years ago • 6 comments

I'm using outlines with URP, and when opening the profiler, I get spammed with errors:

Non matching Profiler.EndSample (BeginSample and EndSample count must match): OutlinePass
Previous 5 samples:
	Gfx.SetRenderTarget
	Outline-1024
	Gfx.SetRenderTarget
	OutlinePass
	Outline-1024
In the scope:
	Outline-1024
	ScriptableRenderer.Execute: BaseRenderer
	UniversalRenderPipeline.RenderSingleCamera: Main Camera
	Render Thread

If I comment out the using (new ProfilingScope(cmd, _profilingSampler)) lines in OutlinePass.cs, the errors go away. Not sure if this is an issue with Unity or the OutlinePass.

mihakrajnc avatar Dec 10 '21 15:12 mihakrajnc

This a duplicate of #44. You can safely remove the line with ProfilingScope reference.

Arvtesh avatar Dec 10 '21 21:12 Arvtesh

I'm going to remove these line for the next version,

Arvtesh avatar Dec 10 '21 21:12 Arvtesh

i get the exact same issue, commenting this line also aleviates it

popcron avatar May 08 '22 04:05 popcron

I notice this issue is still open. How can I comment out the line without it reverting back after package compilation?

BorpaBoatski avatar Mar 10 '23 14:03 BorpaBoatski

I notice this issue is still open. How can I comment out the line without it reverting back after package compilation?

Try installing is as local package (https://docs.unity3d.com/Manual/upm-ui-local.html). This should allow editing it as you like.

abogarsukov-braingames avatar Mar 10 '23 15:03 abogarsukov-braingames

Thanks @abogarsukov-braingames

BorpaBoatski avatar Mar 13 '23 08:03 BorpaBoatski