Articy3ImporterForUnreal
Articy3ImporterForUnreal copied to clipboard
Fixed EArticyPausableType bit flags to be used correctly
- The EArticyPausableType was not set up correctly, causing pause events to happen when they shouldn't. Changed the enum to use proper bit flags which fixed the issue.
- Removed the SetPauseOn function since it is no longer needed as you can set the public PauseOn variable directly (it also had the enum entries in the wrong order)
Upvoted!
@lpinkhard I ran into an issue while implementing Articy in C++. SetPauseOn wasn't behaving as expected. The code in this PR solved my problem.
Prior to using the code in the PR I was using SetPauseOn in the following manner:
ArticyFlowPlayer->SetPauseOn(EArticyPausableType::Dialogue);
ArticyFlowPlayer->SetPauseOn(EArticyPausableType::DialogueFragment);
The result was that it would pause on Flow which was unintended. Luckily I was aware of this PR and had kept it in mind during my implementation. I copied his changes into my clone of this repo and switch the snippet above to:
ArticyFlowPlayer->PauseOn = uint8(EArticyPausableType::Dialogue) | uint8(EArticyPausableType::DialogueFragment);
This worked as intended.
I wanted to give some more context and bring this PR to your attention so that it might be integrated / tested for use in master and for anyone else who stumbles on this issue.