Results 218 comments of Arnav Singh
trafficstars

Yeah just checked again before I do a release, and it's still there, so I'd rather not remove it for now. Since Rust and the crates.io ecosystem (including k8s-openapi) generally...

As I mentioned in #5933, will this not be a breaking change for assigning object literals to class types? ``` typescript class Foo { constructor(public prop: string) { } }...

Hmm, I didn't think of the `NaN` behavior. That makes me lean towards removing that the `f32::clamp` and `f64::clamp` suggestions from this lint. Clippy shouldn't assume the user has non-NaN...

> ```rust > error: chaining calls to `min` and `max` > --> $DIR/clamp.rs:4:25 > | > LL | let minmax_method = 10.min(5).max(15); > | ^^^^^^^^^^^^^^^^^ help: replace with `clamp`: `10.clamp(5,...

No. One lint should do one thing. `min_max` should lint about the arguments being backwards. `clamp` should warn about using `clamp`. You don't need any "dependency" between lints. You just...

Previous discussion of merging derive-error-chain into this repository is at https://github.com/Arnavion/derive-error-chain/issues/11 If the goal is to completely replace the existing macro_rules macro with a custom derive, then my concerns in...

I don't think derive-error-chain is involved, right? It seems to me the situation is that crate A uses error-chain with the backtrace feature and does not expose a feature to...

`cause()` and `from()` don't do anything in error-chain. You can remove them. ~~>you need to implement `From` manually.~~ ~~Why do you need to implement manually? If you're talking about an...

Superseded by #121

Okay, I've updated [pr/121](https://github.com/Arnavion/k8s-openapi/compare/pr/121) with the change to the custom derive to make the impl of `DeepMerge` for the generated CR type opt-in. If you're okay with that branch, I'll...