arduino_ci icon indicating copy to clipboard operation
arduino_ci copied to clipboard

Big fix branch for 2021

Open ianfixes opened this issue 4 years ago • 4 comments

There are a lot of interrelated things to fix, so this branch intends to be a heavy-handed attempt to combine all those fixes.

Highlights from CHANGELOG.md

  • See CHANGELOG.md for more

Issues Fixed

  • Fixes #295
  • Fixes #283
  • Supersedes #285
  • Fixes #282
  • Supersedes #297
  • Fixes #288
  • Supersedes #289
  • Supersedes #298
  • Supersedes #286
  • Fixes #269
  • Supersedes #290
  • Addresses #280

ianfixes avatar Apr 04 '21 18:04 ianfixes

I have two fixes you can cherry-pick from the branch 2021-02-15_beta.update. The first one is trivial, but the second one about the --path argument I am not sure if is correct, so maybe just use that as a reference to investigate what the correct commands should be.

With the crlf branch merged into master, you can drop the commit "Update CHANGELOG.md to describe line endings change." from this branch.

hlovdal avatar Apr 05 '21 19:04 hlovdal

@hlovdal It doesn't look like there's too much to bring over https://github.com/ianfixes/arduino_ci/compare/2021-02-15_beta...hlovdal:2021-02-15_beta.update

ianfixes avatar Apr 07 '21 20:04 ianfixes

@jgfoster I'll try to break this up into smaller pieces so we can get it merged in, but I'm not sure which of the issues fixed (see PR description) are most pressing

ianfixes avatar Oct 04 '21 14:10 ianfixes

@ianfixes, That's fine. As you have seen, I've merged most of my changes. The one remaining is the one to build a library once and use it for the remaining tests. While this has had an enormous speed improvement in our application, I'm not seeing the same improvement in the TestSomething case. For that reason I'm holding back and on merging it till I can better document the improvement.

As to the other PRs, I do intend to review them and merge them as I understand what is happening (I've given my own preferential treatment since I understand them!).

jgfoster avatar Oct 04 '21 14:10 jgfoster

Pulled into #334 with the exception of https://github.com/Arduino-CI/arduino_ci/commit/1ee342c18740e665b265cc81af346c9ee160c208

ianfixes avatar Dec 22 '22 17:12 ianfixes

This has merged as part of #334 and was released in v1.4.0. https://github.com/Arduino-CI/arduino_ci/commit/1ee342c18740e665b265cc81af346c9ee160c208 is being tracked in #337

ianfixes avatar Dec 28 '22 13:12 ianfixes