ardupilot
ardupilot copied to clipboard
colcon: Use current MAVProxy and flake8 in GitHub Action
This GitHub Action fails occasionally, so let's upgrade its tools to see if that provides more stable runs.
https://pypi.org/project/MAVProxy --> v1.8.71 https://pypi.org/project/flake8 --> v7.2.0
Given the changes in MAVProxy, should we upgrade?
- https://github.com/ArduPilot/MAVProxy/releases
flake8: Both the local issue and the flake8 issue it points to were closed 4 or 5 years ago, so let's test with current flake8.
pip install -U can be quite opaque to readers because pip install currently has six --u* options.
% python3 -m pip install --help | grep "\-\-u"
--user Install to the Python user install directory for
-U, --upgrade Upgrade all specified packages to the newest
--upgrade-strategy <upgrade_strategy>
--use-pep517 Use PEP 517 for building source distributions
--use-feature <feature> Enable new functionality, that may be backward
--use-deprecated <feature> Enable deprecated functionality, that will be
This GitHub Action fails occasionally, so let's upgrade its tools to see if that provides more stable runs.
I very much doubt this will help; the errors are some sort of race condition in DDS code generation IIUC.
Still, not a bad change IMO if it passes CI. @Ryanf55 or @srmainwaring will need to approve this, 'though
Please hold off on merge till we get an answer from upstream on if we should be using the latest flake8.
I suspect the answer is no, use apt install python3-flake8
Please hold off on merge till we get an answer from upstream on if we should be using the latest flake8. I suspect the answer is no, use
apt install python3-flake8
I'm not understanding this stance. For starters, not everyone is using apt for their package management.
I am going to split this into two separate PRs
- This one will focus on
flake8given the complexities of the extra layer ofament-flake8. - #30414 (merged) can focus on running tests using the current MAVProxy release.
Looks like everyone has approved... Are there remaining todos on this one?
Merged, thanks! This did kind of stick out as odd.