Add osd switching via stick inputs in disarm state

[prosolvo4th]

Sticks inputs: roll mid && pitch high && yaw low && throttle mid

[Hwurzburg]

needs Andy's approval that this does not interfere with his param change code

[andyp1per]

Pretty sure this is going to interact very badly with the param stuff and runcam menus. I think probably at a minimum you need to check that you are not in the runcam osd menus and disable this behaviour if you are. The param stuff is the same I think - you need to check you are not in these menus when enabling this stuff.

[prosolvo4th]

Need to check whether you are in runcam or OSD parameter menus

Hi! I added checking for the runcam menu state (kind of). But I don't want to add a check on Screen5 or Screen6. I use this functionality to go to Screen5 to adjust the VTX.

For now, there is no interference between the param menu and the used stick combination. For the param menu throttle (left stick in mode2) must be in the lower position, in the proposed PR for switching between OSD screens throttle must be in the center.

[andyp1per]

Need to check whether you are in runcam or OSD parameter menus

Hi! I added checking for runcam menu state (kind of). But I don't want to add a check on Screen5 or Screen6. I use this functionality to go to Screen5 to adjust the VTX.

Does it work ok? I mean if its working well with the parameter menus then that's great.

[prosolvo4th]

Need to check whether you are in runcam or OSD parameter menus

Hi! I added checking for runcam menu state (kind of). But I don't want to add a check on Screen5 or Screen6. I use this functionality to go to Screen5 to adjust the VTX.

Does it work ok? I mean if its working well with the parameter menus then that's great.

yep, so far so good

[prosolvo4th]

@Hwurzburg Here are changes in the wiki: https://github.com/ArduPilot/ardupilot_wiki/pull/6278

[peterbarker]

Byte-cost for this feature:

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           272     272               272    272    *
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           120     120               120    112    *
MatekF405                           *      *           112     112               120    112    *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           120     112               120    112    *
skyviper-v2450                                         *                                       

[peterbarker]

... also has to pass CI

[prosolvo4th]

... also has to pass CI

This can be quite difficult. For some reason sometimes tests can fail for no reason. I created a simple change and PR with this change in my fork, and CI failed in 2 checks. I am afraid, I am not able to get a CI 100% pass...

[andyp1per]

We don't care if RunCam is preventing arming.

We care that we're in the RunCam menus.

So use an appropriately-named method.

We do internally. I object to this rename internally, but fine for it to be used externally.