ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AC_AttitudeControl: ensure yaw gets a FLTD default

Open andyp1per opened this issue 1 year ago • 2 comments

When people come to tune yaw D they need to have a FLTD set. There is no downside to not setting this by default

andyp1per avatar Feb 19 '24 18:02 andyp1per

I have it on the tuning guide, but a default is even better

amilcarlucas avatar Feb 19 '24 18:02 amilcarlucas

After the meeting I believe the only change needed for clarity is the name of the variable to include Y for yaw. AC_ATC_MULTI_RATE_RP_FILT_HZ to AC_ATC_MULTI_RATE_RPY_FILT_HZ

lthall avatar Feb 22 '24 10:02 lthall

I've cherry-picked Leonard's fixes for the naming into this PR.

In addition to fixing the defines in AP_CustomControl he's fixed the same defines in Copter.

I've tested that there's no compiler output change vs Andy's patch, so I believe that the one objection brought up at DevCall has been addressed. I'm marking this as MergeOnCIPass.

peterbarker avatar Feb 23 '24 06:02 peterbarker