ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Support for ElfinH7 Wing

Open suiaiyun opened this issue 2 years ago • 10 comments

suiaiyun avatar Aug 08 '23 06:08 suiaiyun

I also suggest you send early prototypes to a few ArduPilot devs so that they can verify and help ...Andrew Tridgell, Andy Piper at least...and I would like to have one to verify user instructions on firmware loading as I make the wiki page for the device...

Hello, do you need to mail it to the developers? May I ask where the address is? At present, this board only has a prototype board and has not started production. If necessary, I can mail the prototype board to the developers.

also a link to your website for the device when its ready

There is currently no relevant website available. If necessary, I will create a corresponding website.

suiaiyun avatar Aug 09 '23 08:08 suiaiyun

I also suggest you send early prototypes to a few ArduPilot devs so that they can verify and help ...Andrew Tridgell, Andy Piper at least...and I would like to have one to verify user instructions on firmware loading as I make the wiki page for the device...

Hello, do you need to mail it to the developers? May I ask where the address is? At present, this board only has a prototype board and has not started production. If necessary, I can mail the prototype board to the developers.

also a link to your website for the device when its ready

There is currently no relevant website available. If necessary, I will create a corresponding website.

  1. There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.
  2. if you want to do that then just put your email address here and I will have the addresses emailed to you
  3. having a link to where users will be able to obtain these devices is only needed when the wiki page is to be posted....posting that page (After your PR is merged) can wait until such time its is offered for sale...

Hwurzburg avatar Aug 09 '23 11:08 Hwurzburg

There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.

This is great. Do I need to provide the schematic diagram of the board to the developers? As this is the first time submitting a PR for a new board, please forgive me for not clarifying what needs to be sent to the developers.

suiaiyun avatar Aug 09 '23 14:08 suiaiyun

There is no requirement to send the boards, but it will allow us to provide assistance during your development, help assure nothing is overlooked and provide a means to help answer questions on any issues that might arise from you or your customers more quickly.

This is great. Do I need to provide the schematic diagram of the board to the developers? As this is the first time submitting a PR for a new board, please forgive me for not clarifying what needs to be sent to the developers.

having a schematic is always helpful....we are very careful to use only with lead developers... I have discussed internally and the plane lead feels it important that I get a board as soon as possible to run user oriented trials on the external QSPI setup....its new and only one dev has played with this function....if that is possible....my email is [email protected] and I can send you details if you wish

Hwurzburg avatar Aug 10 '23 01:08 Hwurzburg

having a schematic is always helpful....we are very careful to use only with lead developers... I have discussed internally and the plane lead feels it important that I get a board as soon as possible to run user oriented trials on the external QSPI setup....its new and only one dev has played with this function....if that is possible....my email is [email protected] and I can send you details if you wish

Hello. The schematic diagram of the ElfinH7 Wing board has been sent to your email. Thank you for your review.

suiaiyun avatar Aug 10 '23 02:08 suiaiyun

@suiaiyun any updates? is the project still alive?

Hwurzburg avatar Dec 13 '23 12:12 Hwurzburg

@suiaiyun any updates? is the project still alive?

Yes, it is still alive, but encountered a problem. I asked a question in the discussion, but did not receive a clear response. https://discuss.ardupilot.org/t/plane-4-4-release/99954/141

suiaiyun avatar Dec 13 '23 12:12 suiaiyun

that is because you are using customized code,and Tridge wont spend much time on trying to figure out what wrong....I would test this PR on master so CAN support is there, with normal param storage,not on sd card....then if this is proven and working on your controller, this PR can go into master...THEN you can do customized things like sd card param storage,etc. also you need to get boards to Tridge,etc if you expect real help bringing up a new board...also, reserve the board id separately in a separate PR asap

Hwurzburg avatar Dec 13 '23 13:12 Hwurzburg

@suiaiyun any update?

Hwurzburg avatar Jan 18 '24 14:01 Hwurzburg

@peterbarker I suggest removing the board support label so it stops coming up on my list....its been abondoned or is inactive

Hwurzburg avatar Sep 10 '24 11:09 Hwurzburg

@suiaiyun please open a fresh PR if you want to add support for this board; a new board ID will need to be allocated.

I strongly suggest you separate any other code changes from adding support for this new board - if you want to make logical changes to flight code that deserves separate PR, and I think that's what might have gone wrong with this one.

peterbarker avatar Sep 12 '24 12:09 peterbarker

@suiaiyun and I cant seem to find the email in August where you said you sent me the schematic...if you decide to reopen a PR for this board please resend the schematic...thanks

Hwurzburg avatar Sep 12 '24 12:09 Hwurzburg