ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

AP_Mount: send text feedback when gimbal gets detected

Open amilcarlucas opened this issue 3 years ago • 3 comments

amilcarlucas avatar Jun 10 '22 16:06 amilcarlucas

ideally it would not be send then the gimbal is detected (initialized) but whenever it is "needed"

I do it by linking it to send banner (the banner appears to me to be always send out when e.g. a gcs connects, so it appeared to me to be not too bad, but there might better ways) https://github.com/olliw42/BetaPilot/blob/BetaCopter41/libraries/GCS_MAVLink/GCS_Common.cpp#L3655-L3658 https://github.com/olliw42/BetaPilot/blob/BetaCopter41/libraries/GCS_MAVLink/GCS_Common.cpp#L3655-L3658 just as an idea

olliw42 avatar Jun 13 '22 10:06 olliw42

Ping @amilcarlucas - suggestions have been made here

peterbarker avatar Sep 15 '22 00:09 peterbarker

I think @olliw42's suggestion is a good one. If we want the user to reliably see the message then linking to the banner is probably the best way to do it.

So I think the question becomes whether displaying the gimbal info is important enough. Comparing to other subsystems, we do display Servo output info in the banner because we found users were having troubles getting the outputs configured correctly (because the setup is complex) especially when using DShot/BLheli. If we take it to the extreme then every subsystem would display something in the banner which would result in a huge block of text sent to the GCS each time the parameters are downloaded. Maybe that would be useful and maybe then the issue would just become how often it is displayed which is a different issue we could fix as well.

rmackay9 avatar Sep 16 '22 00:09 rmackay9

OK, implemented Randy suggestion and all tests pass

amilcarlucas avatar Feb 13 '24 15:02 amilcarlucas

Recently we're using GCS_SEND_TEXT more than gcs().send_txt() but I've merged anyway to keep things moving along.

rmackay9 avatar Feb 14 '24 00:02 rmackay9