ardupilot
ardupilot copied to clipboard
Add Mount RC failsafe handling
@Hwurzburg
Maybe s/in_rc_failsafe/in_failsafe/
want me to SITL and bench test this? and close mine?
want me to SITL and bench test this? and close mine?
Yes please!
On Fri, 8 Jan 2021, Pierre Kancir wrote:
looks like we can merge the two cases
Read a little harder. They look very similar :-)
On Fri, 8 Jan 2021, Pierre Kancir wrote:
looks like is miss some indent here
Yeah, I retained the original indent for no particularly good reason.
One word : dyslexia ;-S
I tried the pure-virtual thing. It didn't work out. Too much stuff to be reverted when we move the failsafe handling up.
@peterbarker having a problem running SITL on this...if I use master/realfight griffin to get the mount, setting SIM_RC_FAIL puts it into failsafe...if I load this, it just disconnects RC from the controller box...maybe its a flightaxis thing...but cant test in STIL as is
btw, noticed that if I use RC mavproxy command it overrides the flight axis control box for that channel until I set RC X 0....probably should document...I assume it also does this in pure Mavproxy if joystick module is used?
Closes https://github.com/ArduPilot/ardupilot/issues/24093
We decided to use an option bit instead of adding the extra parameter, thanks!