ardupilot icon indicating copy to clipboard operation
ardupilot copied to clipboard

Add Mount RC failsafe handling

Open peterbarker opened this issue 4 years ago • 11 comments

@Hwurzburg

peterbarker avatar Jan 07 '21 01:01 peterbarker

Maybe s/in_rc_failsafe/in_failsafe/

peterbarker avatar Jan 07 '21 01:01 peterbarker

want me to SITL and bench test this? and close mine?

Hwurzburg avatar Jan 07 '21 22:01 Hwurzburg

want me to SITL and bench test this? and close mine?

Yes please!

peterbarker avatar Jan 08 '21 02:01 peterbarker

On Fri, 8 Jan 2021, Pierre Kancir wrote:

looks like we can merge the two cases

Read a little harder. They look very similar :-)

peterbarker avatar Jan 08 '21 11:01 peterbarker

On Fri, 8 Jan 2021, Pierre Kancir wrote:

looks like is miss some indent here

Yeah, I retained the original indent for no particularly good reason.

peterbarker avatar Jan 08 '21 11:01 peterbarker

One word : dyslexia ;-S

khancyr avatar Jan 08 '21 12:01 khancyr

I tried the pure-virtual thing. It didn't work out. Too much stuff to be reverted when we move the failsafe handling up.

peterbarker avatar Jan 12 '21 10:01 peterbarker

@peterbarker having a problem running SITL on this...if I use master/realfight griffin to get the mount, setting SIM_RC_FAIL puts it into failsafe...if I load this, it just disconnects RC from the controller box...maybe its a flightaxis thing...but cant test in STIL as is

Hwurzburg avatar Jan 12 '21 15:01 Hwurzburg

btw, noticed that if I use RC mavproxy command it overrides the flight axis control box for that channel until I set RC X 0....probably should document...I assume it also does this in pure Mavproxy if joystick module is used?

Hwurzburg avatar Jan 12 '21 15:01 Hwurzburg

Closes https://github.com/ArduPilot/ardupilot/issues/24093

peterbarker avatar May 07 '24 07:05 peterbarker

We decided to use an option bit instead of adding the extra parameter, thanks!

rmackay9 avatar May 08 '24 08:05 rmackay9