MissionPlanner icon indicating copy to clipboard operation
MissionPlanner copied to clipboard

ConfigRawParams: When setting a parameter changes the number of parameters, do a full refresh. and check if reboot is needed

Open EosBandi opened this issue 1 year ago • 6 comments

If a param change causing the change in the number of parameters, the parameter subsystem could stuck in a "downloading is in progress" state. This pr: removes the name check, since not only _enable parameters can change the number of parameters Add a check at the end of Write Params and if the reported param number not equals with the current number, it notify the user and do a param refresh. This fixes #3198

EosBandi avatar Jan 06 '24 04:01 EosBandi

THANKS! I see the build artifact but not sure how to run it locally for some testing....its an aab file?

Hwurzburg avatar Jan 07 '24 13:01 Hwurzburg

param refresh dangerous when armed, as low bandwidth or long range links can be adversely affected - i support it if its tweaked to only do this when disarmed.

davidbuzz avatar Jan 08 '24 23:01 davidbuzz

PeterH suggested that we should only do the full refresh when the vehicle is disarmed.

rmackay9 avatar Jan 08 '24 23:01 rmackay9

while testing I got this error: image may or may not be related

Otherwise seems to work well....I agree with Pete's comment re refresh only while disarmed...

this PR is really needed!!! thanks

Hwurzburg avatar Jan 14 '24 13:01 Hwurzburg

while testing I got this error: Based on where it happened in the code, this is unrelated. Do you have steps to repro ?

Otherwise seems to work well....I agree with Pete's comment re refresh only while disarmed...

Indeed, added check for armed state.

EosBandi avatar Jan 15 '24 08:01 EosBandi

@EosBandi will try to reproduce...I was just randomly enablilng/changing parameters that I know need reboots

Hwurzburg avatar Jan 15 '24 13:01 Hwurzburg