MissionPlanner icon indicating copy to clipboard operation
MissionPlanner copied to clipboard

MavlinkNumericUpDown: adjusted to consider scale for Min and Max values

Open tatsuy opened this issue 1 year ago • 2 comments

Implemented unit conversion for RTL_ALT's minimum and maximum values in Geo Fence screen to allow setting RTL Altitude[m] below 200m.

"RTL Altitude[m]" on the Geo Fence screen cannot be set to less than the current setting. image

The setting must be changed in the Full Parameter List.

The cause was that the minimum value for RTL_ALT is 200 cm and the conversion of units is not taken into account. In this PR, units are now taken into account for the minimum and maximum.

tatsuy avatar Dec 21 '23 13:12 tatsuy

i question this change. as i think it will have large effects on other params

meee1 avatar Jan 12 '24 04:01 meee1

Yes, it has an overall impact. I have also confirmed the following other parameters. PSC_VELXY_IMAX PSC_ACCZ_IMAX image

If this modification is not applied, it could inadvertently set an out-of-range value. ex. set PSC_VELXY_IMAX to 4500 on Extended Tuning screen image

It will set 4500*10 (the scale value) image

I think it would be correct to consider scale in all parameters.

tatsuy avatar Jan 14 '24 02:01 tatsuy