[Bug] MobileToolbarV2 shows unnecessary space when keyboard is out

[saif-ellafi]

Bug Description

Not sure if I am doing anything wrong, but there is a padding space of proportional size to toolbarHeight when the keyboard is up. This happens to be inside the Widget Column inside MobileToolbarV2

How to Reproduce

Follow the MobileToolbarV2 example and try on a mobile phone. When the keyboard is up, a large padding area shows at the bottom inside MobileToolbarV2

Expected Behavior

The extra space is not necessary

Operating System

Android

AppFlowy Editor Version(s)

4.0.0

Screenshots

No response

Additional Context

No response

[saif-ellafi]

@LucasXu0 - I think the ValueListenableBuilder on Keyboard being shown is not needed on MobileToolbarV2 as per in the screenshot, the toolbar is alwalys on top of the keyboard, or at least it can be managed by the rest of the app.

[LucasXu0]

@saif-ellafi Can you share the code sample? The empty padding should be related to the toolbarHeight setting. I can't reproduce it in the example app or appflowy app.

[saif-ellafi]

Hello @LucasXu0 - just FYI yes this happens when my editor is, in this case, in a Popup Dialog. For now I am using in production the Desktop editor with a toolbar in all devices.

my app is complex but I hope these snippets help somehow? I am not doing anything fancy, other than this is inside a Column with expanded rich editor

                          Container(
                            padding: EdgeInsets.symmetric(horizontal: 5.0),
                            decoration: BoxDecoration(
                              border: Border.all(
                                width: 1.5,  
                                color: PUMCompanion.gameTheme.tertiaryTextStyle.color!,
                              ),
                              borderRadius: PUMCompanion.gameTheme.borderRadius,
                            ),
                            child: PopScope(
                              onPopInvokedWithResult: (didPop, popResult) {
                                if (didPop) {
                                  widget.doSaveGame();
                                }
                              },
                              child: Padding(
                                padding: const EdgeInsets.symmetric(vertical: 10.0),
                                child: RichEditorMobile(
                                  // editorState: _textControllers[index][descIndex],
                                  tabs: _tabs,
                                  textControllers: _textControllers,
                                  index: index,
                                  descIndex: descIndex,
                                  widget: widget,
                                  // tabName: _tabs[index],
                                )
                              ),
                            ),
                          ),

  @override
  Widget build(BuildContext context) {

    final editorState = _textControllers[index][descIndex];
    final innerScrollController = ScrollController();
    final editorScrollController = EditorScrollController(
      editorState: editorState,
      scrollController: innerScrollController,
    );
    editorScrollController.scrollController = innerScrollController;

    return MobileToolbarV2(
      toolbarHeight: 40.0,
      toolbarItems: [
        textDecorationMobileToolbarItemV2,
        buildTextAndBackgroundColorMobileToolbarItem(),
        blocksMobileToolbarItem,
        linkMobileToolbarItem,
        dividerMobileToolbarItem,
      ],
      editorState: editorState,
      backgroundColor: PUMCompanion.gameTheme.backgroundColor,
      iconColor: PUMCompanion.gameTheme.primaryTextStyle.color!,
      foregroundColor: PUMCompanion.gameTheme.primaryTextStyle.color!,
      child: MobileFloatingToolbar(
        editorState: editorState,
        editorScrollController: editorScrollController,
        toolbarBuilder: (context, anchor, closeToolbar) {
          return AdaptiveTextSelectionToolbar.editable(
            clipboardStatus: ClipboardStatus.pasteable,
            onCopy: () {
              copyCommand.execute(editorState);
              closeToolbar();
            },
            onCut: () => cutCommand.execute(editorState),
            onPaste: () => pasteCommand.execute(editorState),
            onSelectAll: () => selectAllCommand.execute(editorState),
            onLiveTextInput: null,
            onLookUp: null,
            onSearchWeb: null,
            onShare: null,
            anchors: TextSelectionToolbarAnchors(
              primaryAnchor: anchor,
            ),
          );
        },
        child: AppFlowyEditor(
          editorStyle: _buildMobileEditorStyle(editorState),
          editorState: editorState,
          autoScrollEdgeOffset: 20.0,
          editorScrollController: editorScrollController,
          blockComponentBuilders: _buildBlockComponentBuilders(),
          showMagnifier: true,
        ),
      ),
    );
  }