appflowy-editor icon indicating copy to clipboard operation
appflowy-editor copied to clipboard

fix: incorrect cursor movement behaviour

Open Jei-sKappa opened this issue 1 year ago • 7 comments
trafficstars

fixes #745 Previously the moveVertical function only moved the cursor 'node to node' without taking into consideration multiline nodes or some portion of a line with different fontSize (ex: a paragraph with size 16 but with a bolded word with size 32). This was caused by the PR #657 that closes #656 and #589.

Jei-sKappa avatar Mar 21 '24 13:03 Jei-sKappa

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 21 '24 13:03 CLAassistant

@Jei-sKappa Thanks for contributing. Please format the code.

LucasXu0 avatar Mar 28 '24 07:03 LucasXu0

@LucasXu0 Thanks for your reply! Based on the response of GitHub Action it seems like the problem is in the commit message and not in the code. Am I right?

Jei-sKappa avatar Mar 28 '24 08:03 Jei-sKappa

@LucasXu0 Thanks for your reply! Based on the response of GitHub Action it seems like the problem is in the commit message and not in the code. Am I right?

Except for the commit message, you need to format the Dart code too. Please click on the CI and check the error.

LucasXu0 avatar Mar 28 '24 08:03 LucasXu0

@LucasXu0 Sorry for the late response. I just pushed a new update to the pull requests that should fix the test's errors in the CI. Unfortunately my first commit text exceeds the length defined in commitlint and the CI keeps failing 'cause of this. Can I ignore it? If not what should I do to fix this?

Jei-sKappa avatar Apr 13 '24 15:04 Jei-sKappa

Codecov Report

Attention: Patch coverage is 97.87234% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.86%. Comparing base (61d892a) to head (ebf0718). Report is 8 commits behind head on main.

Files Patch % Lines
lib/src/extensions/position_extension.dart 97.87% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   75.29%   74.86%   -0.44%     
==========================================
  Files         300      300              
  Lines       14011    14178     +167     
==========================================
+ Hits        10550    10614      +64     
- Misses       3461     3564     +103     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 15:04 codecov[bot]

Can I ignore it? If not what should I do to fix this?

You don't have to worry about the commitlint failing, it's not important :+1:

Xazin avatar Apr 16 '24 15:04 Xazin